Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not possible to change Monaco keybindings #6878

Closed
akosyakov opened this issue Jan 14, 2020 · 0 comments · Fixed by #6880
Closed

not possible to change Monaco keybindings #6878

akosyakov opened this issue Jan 14, 2020 · 0 comments · Fixed by #6880
Assignees
@akosyakov
Labels
bug bugs found in the application keybindings issues related to keybindings monaco issues related to monaco

Comments

@akosyakov
Copy link
Member

akosyakov commented Jan 14, 2020 •
edited
Loading

Monaco keybinding service reacts on default keybindings, even if we change in Theia. So a user don't have a way to change such keybindings. We should replace this service with no-op implementation.

Originally reported in Gitpod: gitpod-io/gitpod#1060
@akosyakov akosyakov added bug bugs found in the application keybindings issues related to keybindings monaco issues related to monaco labels Jan 14, 2020
@akosyakov akosyakov self-assigned this Jan 14, 2020
akosyakov added a commit that referenced this issue Jan 14, 2020
@akosyakov
[keybinding] fix #6878: allow a user to change default keybindings
754ee2f 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Jan 14, 2020
Merged
1 task
akosyakov added a commit that referenced this issue Jan 14, 2020
@akosyakov
[keybinding] fix #6878: allow a user to change default keybindings
1a4ba8c 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 15, 2020
@akosyakov
[keybinding] fix #6878: allow a user to change default keybindings
ea5fd09 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 16, 2020
@akosyakov
[keybinding] fix #6878: allow a user to change default keybindings
bdd39e8 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 17, 2020
@akosyakov
[keybinding] fix #6878: allow a user to change default keybindings
d5f4a86 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@gbodeen gbodeen mentioned this issue Feb 11, 2020
Closed
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[keybinding] fix eclipse-theia#6878: allow a user to change default k…
4b16da9 
…eybindings

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application keybindings issues related to keybindings monaco issues related to monaco
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow a user to change default keybindings eclipse-theia/theia
1 participant
@akosyakov