allow a user to change default keybindings #6880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
requested review from
vince-fugnitto,
JPinkney,
paul-marechal and
spoenemann
akosyakov
added
keybindings
akosyakov
force-pushed
the
akosyakov/not-possible-to-change-6878
branch
from
754ee2f to
1a4ba8c
Compare
spoenemann
reviewed
Jan 14, 2020
There was a problem hiding this comment.
I tested with "Toggle Line Comment" and "Indent Line". I confirm that the default keybinding does not work anymore after changing it in the Keyboard Shortcuts editor. But the new keybinding does not work either:
- the old keybinding is still shown in the shortcuts editor
- the old keybinding is still shown in the Quick Open dialog
- pressing the new keybinding does nothing
akosyakov
force-pushed
the
akosyakov/not-possible-to-change-6878
branch
from
1a4ba8c to
ea5fd09
Compare
|
@spoenemann could you try again please? I've addressed your issues. |
spoenemann
approved these changes
Jan 15, 2020
akosyakov
force-pushed
the
akosyakov/not-possible-to-change-6878
branch
2 times, most recently
from
1bdfcf8 to
ab9654b
Compare
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
to display proper keybinding in the quick command palette Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov
force-pushed
the
akosyakov/not-possible-to-change-6878
branch
from
ab9654b to
47ac870
Compare
|
@vince-fugnitto It should be fixed. |
|
@vince-fugnitto Did it work for you now? |
vince-fugnitto
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Review checklist
Reminder for reviewers