Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode webview input tag cannot enter anything #7232

Closed
huangjunjia opened this issue Feb 27, 2020 · 2 comments · Fixed by #7233
Closed

vscode webview input tag cannot enter anything #7232

huangjunjia opened this issue Feb 27, 2020 · 2 comments · Fixed by #7233
Labels
bug bugs found in the application critical critical bugs / problems webviews issues related to webviews

Comments

@huangjunjia
Copy link

Description

vscode extension create a webview but input element cannot enter anything.

Reproduction Steps

  1. vscode extension create a webview
  2. Enter characters in the input element

OS and Theia version:
image

Diagnostics:

image
@akosyakov
Copy link
Member

akosyakov commented Feb 27, 2020 •
edited
Loading

@huangjunjia Could you try before this PR: #7216?

cc @azatsarynnyy @vrubezhny @vince-fugnitto Could you check please? If it is the case we have to revert it before the release today. cc @marcdumais-work

@akosyakov akosyakov added bug bugs found in the application critical critical bugs / problems webviews issues related to webviews labels Feb 27, 2020
vince-fugnitto added a commit that referenced this issue Feb 27, 2020
@vince-fugnitto
webview: fix user input
727d3b3 
Fixes #7232

This commit reverts the breaking change of #7216 which
meant that users would not be able to provide keyboard input any
longer in a webview.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Feb 27, 2020
Merged
1 task
@vince-fugnitto
Copy link
Member

@huangjunjia Could you try before this PR: #7216?

cc @azatsarynnyy @vrubezhny @vince-fugnitto Could you check please? If it is the case we have to revert it before the release today. cc @marcdumais-work

I confirmed it is caused by #7216 and have provided a fix #7233

vince-fugnitto added a commit that referenced this issue Feb 27, 2020
@vince-fugnitto
webview: fix user input
fe417a8 
Fixes #7232

This commit reverts the breaking change of #7216 which
meant that users would not be able to provide keyboard input any
longer in a webview.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
@vince-fugnitto
webview: fix user input
130cf3b 
Fixes eclipse-theia#7232

This commit reverts the breaking change of eclipse-theia#7216 which
meant that users would not be able to provide keyboard input any
longer in a webview.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@azatsarynnyy azatsarynnyy mentioned this issue Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application critical critical bugs / problems webviews issues related to webviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

webview: fix user input eclipse-theia/theia
3 participants
@akosyakov @huangjunjia @vince-fugnitto