-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent default handling for the browser reserved hotkeys inside webviews #7216
Conversation
…iews Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified the pull-request using the coding-cat example. I was able to trigger the command palette and search using keybindings (something that was not possible when on master
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified the pull-request using the coding-cat example. I was able to trigger the command palette and search using keybindings (something that was not possible when on master
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! 👍
Works nicely now. I've tested in Chrome and FireFox.
Fixes eclipse-theia#7232 This commit reverts the breaking change of eclipse-theia#7216 which meant that users would not be able to provide keyboard input any longer in a webview. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
What it does
This changes proposal prevents calling default browser hotkeys, such as
CtrlCmd+P
,CtrlCmd+O
inside Web Views, when the last one is under focus.Related issue: eclipse-che/che#15763
State in master:
State with current changes:
Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com
How to test
Use sample extension https://github.com/microsoft/vscode-extension-samples/tree/master/webview-sample and try to call default browser hotkey.
Review checklist
Reminder for reviewers