Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to open a new file or folder if the preference editor is opened #7253

Closed
lmcbout opened this issue Mar 2, 2020 · 1 comment
Closed
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help preferences issues related to preferences

Comments

@lmcbout
Copy link
Contributor

lmcbout commented Mar 2, 2020

Description

Unable to open a new File or Folder in a workspace when the Preference editor is opened

Reproduction Steps

Open a workspace
Open a java file
Open the preference editor
Try to open from the menu context: File -> New File ==> DO NOT WORK
Try to open from the menu context: File -> New Folder ==> DO NOT WORK

OS and Theia version:
OS: Ubuntu 18.04
Theia: latest commit e48b9b5
Web: Chrome and Electron

Diagnostics:

DialogNotWithpreferenceEditor

@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help preferences issues related to preferences labels Mar 2, 2020
@vince-fugnitto
Copy link
Member

Duplicate of #7067

@vince-fugnitto vince-fugnitto marked this as a duplicate of #7067 Mar 2, 2020
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Mar 9, 2020
Fixes: eclipse-theia#7067 , eclipse-theia#7253

Initially we were unable to create a new file or folder while the user preferences was open.

The user-preferences has the file scheme set as `user-storage` and we did not fall back to the workspace root URI and instead were getting the URI from 'user_storage:settings.json'.
With this approach, we create files at certain directories and if a directory doesn't have the scheme set to 'file' it will fallback to the workspace root uri.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Mar 10, 2020
Fixes: eclipse-theia#7067 , eclipse-theia#7253

Initially we were unable to create a new file or folder while the user preferences was open.

The user-preferences has the file scheme set as `user-storage` and we did not fall back to the workspace root URI and instead were getting the URI from 'user_storage:settings.json'.
With this approach, we create files at certain directories and if a directory doesn't have the scheme set to 'file' it will fallback to the workspace root uri.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Mar 10, 2020
Fixes: eclipse-theia#7067 , eclipse-theia#7253

Initially we were unable to create a new file or folder while the user preferences was open.

The user-preferences has the file scheme set as `user-storage` and we did not fall back to the workspace root URI and instead were getting the URI from 'user_storage:settings.json'.
With this approach, we create files at certain directories and if a directory doesn't have the scheme set to 'file' it will fallback to the workspace root uri.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
lmcbout pushed a commit that referenced this issue Mar 25, 2020
Fixes: #7067 , #7253

Initially we were unable to create a new file or folder while the user preferences was open.

The user-preferences has the file scheme set as `user-storage` and we did not fall back to the workspace root URI and instead were getting the URI from 'user_storage:settings.json'.
With this approach, we create files at certain directories and if a directory doesn't have the scheme set to 'file' it will fallback to the workspace root uri.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help preferences issues related to preferences
Projects
None yet
Development

No branches or pull requests

3 participants