Fix creating a new file or folder if the preferences widget is opened.

[Anasshahidd21]

What it does

Fixes: #7067 , #7253

Initially we were unable to create a new file or folder while the user preferences was open.

The user-preferences has the file scheme set as user-storage and we did not fall back to the workspace root URI and instead were getting the URI from user_storage:settings.json.
With this approach, we create files at certain directories and if a directory doesn't have the scheme set to file it will fallback to the workspace root uri.

Signed-off-by: Muhammad Anas Shahid muhammad.shahid@ericsson.com

How to test

• Launch Theia

• Open any workspace

• Go to File>Settings> Open Preferences

• Make sure you are on user tab

• Try creating a new file or folder from File>New File or File> New Folder.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[lmcbout]

If no File or Folder is selected, then the new File | Folder should be created under the first root folder of the workspace, otherwise, the new File | Folder should be created under the selected folder. With a multi-root workspace, the new File or Folder can be created under the other root workspace if the focus is on the second root folder

[vince-fugnitto]

If no File or Folder is selected, then the new File | Folder should be created under the first root folder of the workspace, otherwise, the new File | Folder should be created under the selected folder. With a multi-root workspace, the new File or Folder can be created under the other root workspace if the focus is on the second root folder

@lmcbout I'm not sure I understand your comment, when a uri cannot be inferred (for example in the case of opening the preferences widget), then we fallback to the first workspace root. I think this is a fair fallback.

[lmcbout]

If the preference setting is open and the tab is on "User" pref, the "New File | New Folder" crete it in th workspace, but when I select the Preference setting with the "workspace selected", it creates "New File | New Folder" under my /.theia folder which is outside the workspace. It just like you change the order of where the file is created

[vince-fugnitto]

If the preference setting is open and the tab is on "User" pref, the "New File | New Folder" crete it in th workspace, but when I select the Preference setting with the "workspace selected", it creates "New File | New Folder" under my /.theia folder which is outside the workspace. It just like you change the order of where the file is created

It will create a new file/folder wherever the workspace settings is located.
In the case of an untitled workspace file, it will be located in the home.
We can improve the behavior for such a case easily however.

[lmcbout]

If the preference setting is open and the tab is on "User" pref, the "New File | New Folder" crete it in th workspace, but when I select the Preference setting with the "workspace selected", it creates "New File | New Folder" under my /.theia folder which is outside the workspace. It just like you change the order of where the file is created

It will create a new file/folder wherever the workspace settings is located.
In the case of an untitled workspace file, it will be located in the home.
We can improve the behavior for such a case easily however.

Sorry, it create it under <$Home>/.theia , not under the workspce/.theia

[vince-fugnitto]

Sorry, it create it under <$Home>/.theia , not under the workspce/.theia

I understood, untitled workspace (Untitled.theia-workspace) are created under the home and it is the reason why it is displayed.

[lmcbout]

@lmcbout I'm not sure I understand your comment, when a uri cannot be inferred (for example in the case of opening the preferences widget), then we fallback to the first workspace root. I think this is a fair fallback.

I agree with you. When you open the preference settings , no other files, then creating a new "File | Folder" should be done in the first root folder

[Anasshahidd21]

@lmcbout I have updated the code, if you can review.

[lmcbout]

LGTM

[akosyakov]

anything else has to be done before merging?

[Anasshahidd21]

anything else has to be done before merging?

@akosyakov no, its complete imo.

[vince-fugnitto]

anything else has to be done before merging?

@akosyakov no, its complete imo.

@lmcbout I think you can merge