Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stale progress reporting #7311

Closed
akosyakov opened this issue Mar 10, 2020 · 1 comment · Fixed by #7314
Closed

stale progress reporting #7311

akosyakov opened this issue Mar 10, 2020 · 1 comment · Fixed by #7314
Assignees
Labels
bug bugs found in the application notifications issues related to notifications

Comments

@akosyakov
Copy link
Member

I've noticed that progress reporting in the explorer runs forever sometimes. During debugging of such cases I see that all progress tasks are properly cleaned up but progress is still rendered.

I think there is a race condition here:

this.fireEvent(locationId, show);
}
protected readonly fireEvent = throttle((locationId: string, show: boolean) => {
let emitters = this.emitters.get(locationId);
if (!emitters) {
emitters = [ this.addEmitter(locationId) ];
}
emitters.forEach(e => e.fire({ show }));
}, 250);

If several progresses running the last one win cancel out event for previous, so the explorer location never sees done event for instance.

cc @AlexTugarev

@akosyakov akosyakov added bug bugs found in the application notifications issues related to notifications labels Mar 10, 2020
@AlexTugarev AlexTugarev self-assigned this Mar 10, 2020
@vince-fugnitto
Copy link
Member

vince-fugnitto commented Mar 10, 2020

I noticed it today for the debug view:

debug

If it helps, here are the reproduction steps:

  1. open the debug view
  2. click the Start Debugging button ('attach by process id' was selected)
  3. press esc
  4. the progress will be displayed always

AlexTugarev added a commit that referenced this issue Mar 11, 2020
Fixes #7311
AlexTugarev added a commit that referenced this issue Mar 11, 2020
Fixes #7311
AlexTugarev added a commit that referenced this issue Mar 11, 2020
Fixes #7311
AlexTugarev added a commit that referenced this issue Mar 11, 2020
AlexTugarev added a commit that referenced this issue Mar 11, 2020
Fixes #7311

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
AlexTugarev added a commit that referenced this issue Mar 11, 2020
Fixes #7311

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
AlexTugarev added a commit that referenced this issue Mar 11, 2020
Fixes #7311

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
AlexTugarev added a commit that referenced this issue Mar 11, 2020
Fixes #7311

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
AlexTugarev added a commit that referenced this issue Mar 11, 2020
Fixes #7311

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
AlexTugarev added a commit that referenced this issue Mar 11, 2020
Fixes #7311

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
AlexTugarev added a commit that referenced this issue Mar 11, 2020
Fixes #7311

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
AlexTugarev added a commit that referenced this issue Mar 11, 2020
Fixes #7311

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
akosyakov pushed a commit that referenced this issue Mar 11, 2020
Fixes #7311

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application notifications issues related to notifications
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants