-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIx missing progress events #7314
Conversation
e522474
to
7e403e5
Compare
7e403e5
to
9b55097
Compare
9745c83
to
915c414
Compare
915c414
to
2ce9078
Compare
@akosyakov still having
✔️ resolved |
Fixes #7311 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
2ce9078
to
211e161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise looks good but will be good to test as well.
I've tested by:
@AlexTugarev thank you! |
Fixes #7311
What it does
Fixes missing progress events which led to stale location progress'
How to test
Not sure how to reproduce, but if you switch between Explorer, Search, Debug views frequently and do some work there, i.e. generate some progress, you should always see the progress bar disappear, when the tasks are done.
I've added a test cases for this, and without this change the events for "scm" aren't logged at all.
Review checklist
Reminder for reviewers