Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx missing progress events #7314

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

AlexTugarev
Copy link
Contributor

@AlexTugarev AlexTugarev commented Mar 11, 2020

Fixes #7311

What it does

Fixes missing progress events which led to stale location progress'

How to test

Not sure how to reproduce, but if you switch between Explorer, Search, Debug views frequently and do some work there, i.e. generate some progress, you should always see the progress bar disappear, when the tasks are done.

I've added a test cases for this, and without this change the events for "scm" aren't logged at all.

Review checklist

Reminder for reviewers

@akosyakov akosyakov added the progress issues related to the progress functionality label Mar 11, 2020
@AlexTugarev AlexTugarev force-pushed the alextugarev/stale-progress-reporting-7311 branch 2 times, most recently from e522474 to 7e403e5 Compare March 11, 2020 09:55
@AlexTugarev AlexTugarev force-pushed the alextugarev/stale-progress-reporting-7311 branch from 7e403e5 to 9b55097 Compare March 11, 2020 10:30
@AlexTugarev AlexTugarev force-pushed the alextugarev/stale-progress-reporting-7311 branch 3 times, most recently from 9745c83 to 915c414 Compare March 11, 2020 11:29
@AlexTugarev AlexTugarev force-pushed the alextugarev/stale-progress-reporting-7311 branch from 915c414 to 2ce9078 Compare March 11, 2020 11:37
@AlexTugarev
Copy link
Contributor Author

AlexTugarev commented Mar 11, 2020

@akosyakov still having

Uncaught Error: @Inject called with undefined this could mean that the class undefined has a circular dependency problem. You can use a LazyServiceIdentifer to overcome this limitation.

✔️ resolved

Fixes #7311

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
@AlexTugarev AlexTugarev force-pushed the alextugarev/stale-progress-reporting-7311 branch from 2ce9078 to 211e161 Compare March 11, 2020 11:49
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise looks good but will be good to test as well.

@akosyakov
Copy link
Member

akosyakov commented Mar 11, 2020

I've tested by:

  • open the explorer view in the left sidebar
  • open the scm view in the right sidebar
  • limit the connection to 100% package lost
  • trigger refresh in the scm view and open several folders in the explore view
  • wait till progress is reported in both views, it should hang since connection is down
  • disable connection limiting
  • the scm view is successfully refreshed and folders are expanded in the explore view
  • not stale progress indicators

@AlexTugarev thank you!

@akosyakov akosyakov merged commit 07a2616 into master Mar 11, 2020
@akosyakov akosyakov deleted the alextugarev/stale-progress-reporting-7311 branch March 11, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
progress issues related to the progress functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stale progress reporting
2 participants