Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show command category in the keybindings view #7530

Closed
akosyakov opened this issue Apr 8, 2020 · 0 comments · Fixed by #7532
Closed

show command category in the keybindings view #7530

akosyakov opened this issue Apr 8, 2020 · 0 comments · Fixed by #7532
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help keybindings issues related to keybindings

Comments

@akosyakov
Copy link
Member

Several extensions can contribute a command with the same label and keybinding. It is not possible to distinguish which contributed by which currently. Use Find for instance, in Theia they all appear just as Find.

In VS Code they will add Category:
Screenshot 2020-04-08 at 15 30 50
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help keybindings issues related to keybindings labels Apr 8, 2020
vince-fugnitto added a commit that referenced this issue Apr 8, 2020
@vince-fugnitto
keymaps: adjust keybindings-widget
f18b3b9 
Fixes #7530

The following commit includes the changes:
- add the `category` as part of the label for commands which have categories included.
- adjust the sorting of commands (commands with labels should be higher than those without (only id)).

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Apr 8, 2020
Merged
1 task
vince-fugnitto added a commit that referenced this issue Apr 13, 2020
@vince-fugnitto
keymaps: adjust keybindings-widget
cbe76a4 
Fixes #7530

The following commit includes the changes:
- add the `category` as part of the label for commands which have categories included.
- adjust the sorting of commands (commands with labels should be higher than those without (only id)).

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help keybindings issues related to keybindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

keymaps: adjust keybindings-widget eclipse-theia/theia
1 participant
@akosyakov