Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keymaps: adjust keybindings-widget #7532

Merged
merged 1 commit into from
Apr 13, 2020
Merged

keymaps: adjust keybindings-widget #7532

merged 1 commit into from
Apr 13, 2020

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes #7530

The following commit includes the changes:

  • add the category as part of the label for commands which have categories included.
  • adjust the sorting of commands (commands with labels should be higher than those without (only id)).
Screen Shot 2020-04-08 at 10 46 06 AM Screen Shot 2020-04-08 at 10 46 12 AM

How to test

  1. open the keybindings-widget
  2. verify that commands with category correctly display their categories.
  3. verify that the sorting is correct:
    • commands with keybindings should be placed highest
      • commands with labels should be higher than those without (only ids), and should be in alphabetical order
    • commands without keybindings should be placed lower and in alphabetical order

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

Fixes #7530

The following commit includes the changes:
- add the `category` as part of the label for commands which have categories included.
- adjust the sorting of commands (commands with labels should be higher than those without (only id)).

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added keybindings issues related to keybindings commands issues related to application commands ui/ux issues related to user interface / user experience labels Apr 8, 2020
@vince-fugnitto vince-fugnitto self-assigned this Apr 8, 2020
Copy link
Contributor

@Anasshahidd21 Anasshahidd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes against master, and it looks a lot more uniform now. The labels are sorted as desired.

Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in Gitpod. The differences I can tell are that,

  • vscode uses a long dash as a placeholder for empty cells in the When column while Theia doesn't have it.
  • Key names are capitalized in vscode, and not in Theia

In my opinion neither the placehoder or the capitalization is important.

@vince-fugnitto vince-fugnitto merged commit cbe76a4 into master Apr 13, 2020
@vince-fugnitto vince-fugnitto deleted the vf/GH-7530 branch April 13, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands issues related to application commands keybindings issues related to keybindings ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show command category in the keybindings view
3 participants