-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UI test suite #4089
Improve UI test suite #4089
Conversation
b67c017
to
351ccdc
Compare
1c838ef
to
5dda0d6
Compare
4f3cef3
to
2bfaba5
Compare
First time in a long time that I see Appveyor green :) Just clean your commits and should be good to go. |
1db55f1
to
af32b23
Compare
@kittaakos I just wanted your feedback on |
@vince-fugnitto, unti now... as I see you are just taking it over :) Once the build is green, it is good to merge. Right now it's broken:
FYI: since you have bumped up the wdio versions it would be nice to see if we can build with Node.js 10. It does not mean we will switch to Node.js 10. |
af32b23
to
289f062
Compare
f7f1d7d
to
d56790f
Compare
@kittaakos the errors are intermittent, and sometimes occur on master, I really need to try and find the root cause. The purpose of the From my forked theia (with ci enabled), the tests pass https://ci.appveyor.com/project/vince-fugnitto/theia, I'll re-trigger the build on the main repo. |
4177140
to
9abc375
Compare
Since are ui test cases are now faster to execute, I thought increasing the timeouts was acceptable. After this change I noticed travis builds passed consistently each time, and appveyor's intermittent errors (network, timeout, etc.) were more controlled with the additional timeout buffer and retry attempts 😄 I did some research, and it looks like with appveyor's basic plan, performance is not always guaranteed or acceptable, so increasing timeout was a way we can control not exiting our test cases prematurely. |
@marcdumais-work I guess the next step would be to handle the CQ as you mentioned 😄 |
+1. I am working on it now. |
Umbrella CQ registered, for all the repo's dev-dependencies as of ~1h ago: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=18832 . I believe that it covers all dev-dependencies changed in this PR. Since so far we have not had these dev-dependencies CQs, I would not block this PR to wait for approval, if/when otherwise ready to commit. |
6fcbe0e
to
57f10e7
Compare
…an up logging) - Upgraded `chromedriver` to latest compatible version according to chrome version. - Upgraded peer webdriver dependencies. - Reduced "noise" in test cases (removed unneeded logging, and deprecation warnings). - Skip `cpp-change-build-config.ui-spec.ts` test case since it no longer works properly. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
57f10e7
to
66ee7ac
Compare
thank you @marechal-p |
Features:
chromedriver
,webdriverio
and peer dependencies.AppVeyor
test-script into stages (followingtravis.yml
).appveyor-retry
to reduce intermittent failures.cpp-change-build-config.ui-spec.ts
tests.Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com