Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run tests without ts-node in order to speed up the build #4135

Merged
merged 3 commits into from
Jan 22, 2019

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jan 22, 2019

ts-node is still used by:

UI tests can be compiled to js before execution, the script can be rewritten with js or merged into theia CLI. It will improve the speed up as well + completely removing ts-node (and its dependencies) also will improve the speed.

@akosyakov akosyakov force-pushed the ak/run_tests_without_ts_node branch from 611a0b0 to 41154b0 Compare January 22, 2019 08:30
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov force-pushed the ak/run_tests_without_ts_node branch from 41154b0 to dcb7757 Compare January 22, 2019 08:52
@akosyakov
Copy link
Member Author

It dropped the build time from 30m to 17m on travis mac.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Member Author

akosyakov commented Jan 22, 2019

I've split test execution in 3 separate travis scripts that on failure of browser tests all tests are not executed again together. Together with getting of ts-node it dropped Linux build to 18m from 30m.

Browser tests indeed takes only 1 min, but because instability they were executed 3 times by traivs: https://travis-ci.org/theia-ide/theia/jobs/482793895#L5534 Increasing the build time by 3mins, this time debug adapters were downloaded, it is completely internal wdio issue. //cc @marcdumais-work

I've noticed that the slowest unit tests are from extension-manager, since it is not used by anyone and we are going to get rid of it (replacing with plugin UI), i will disable all tests for this extension. It will save some minutes.

They are slow, and the extension is not used by anyone.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Member Author

It's ready for the review. It's 14m instead 30m on Linux with all changes and if UI tests are stable.

@marcdumais-work
Copy link
Contributor

this time debug adapters were downloaded, it is completely internal wdio issue.

We hope this PR will help stabilize the UI tests.

Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test suites pass flawlessly locally on Linux. The Appveyor errors are the usual ones, not apparently made worse by this PR.

@akosyakov akosyakov merged commit a5e2055 into master Jan 22, 2019
@akosyakov akosyakov deleted the ak/run_tests_without_ts_node branch January 22, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants