-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run tests without ts-node in order to speed up the build #4135
Conversation
611a0b0
to
41154b0
Compare
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
41154b0
to
dcb7757
Compare
It dropped the build time from 30m to 17m on travis mac. |
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
I've split test execution in 3 separate travis scripts that on failure of browser tests all tests are not executed again together. Together with getting of ts-node it dropped Linux build to 18m from 30m. Browser tests indeed takes only 1 min, but because instability they were executed 3 times by traivs: https://travis-ci.org/theia-ide/theia/jobs/482793895#L5534 Increasing the build time by 3mins, this time debug adapters were downloaded, it is completely internal wdio issue. //cc @marcdumais-work I've noticed that the slowest unit tests are from |
They are slow, and the extension is not used by anyone. Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
It's ready for the review. It's 14m instead 30m on Linux with all changes and if UI tests are stable. |
We hope this PR will help stabilize the UI tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test suites pass flawlessly locally on Linux. The Appveyor errors are the usual ones, not apparently made worse by this PR.
ts-node is still used by:
UI tests can be compiled to js before execution, the script can be rewritten with js or merged into theia CLI. It will improve the speed up as well
+
completely removing ts-node (and its dependencies) also will improve the speed.