Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligned widget content in sidepanels to header title. #4627

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Aligned widget content in sidepanels to header title. #4627

merged 1 commit into from
Mar 21, 2019

Conversation

jbicker
Copy link
Contributor

@jbicker jbicker commented Mar 20, 2019 •
edited
Loading

Fixes #4622

Some examples:
Screen Shot 2019-03-21 at 11 57 38
Screen Shot 2019-03-21 at 11 55 35
Screen Shot 2019-03-21 at 11 57 56

@jbicker jbicker force-pushed the GH-4622 branch 2 times, most recently from edb7795 to f58fc3a Compare March 20, 2019 16:24
@akosyakov
Copy link
Member

akosyakov commented Mar 21, 2019 •
edited
Loading

I've noticed yesterday that tree views contributed by VS Code extensions are not looking aligned as well. You can reproduce with this extension: https://github.com/akosyakov/vscode-trees See how to test VS Code extensions: https://github.com/theia-ide/theia/wiki/Testing-VS-Code-extensions If it is too hard it could be done separately.

An issue: #4637

@jbicker jbicker changed the title [WIP] Aligned widget content in sidepanels to header title. Aligned widget content in sidepanels to header title. Mar 21, 2019
@jbicker jbicker requested review from akosyakov and svenefftinge and removed request for benoitf and evidolob March 21, 2019 11:09
vince-fugnitto
vince-fugnitto reviewed Mar 21, 2019
View reviewed changes
packages/plugin-ext/src/main/browser/style/plugin-sidebar.css Outdated
}


.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a minor leftover in the file, the extra lines and period :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups, thanks!

.

@jbicker
Aligned widget content in sidepanels to header title.
85944ce 
Fixes #4622

Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
akosyakov
akosyakov approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything seems to be aligned to me

@jbicker jbicker merged commit 25d715f into master Mar 21, 2019
@jbicker jbicker deleted the GH-4622 branch March 21, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto left review comments

@akosyakov akosyakov akosyakov approved these changes

@svenefftinge svenefftinge Awaiting requested review from svenefftinge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbicker @akosyakov @vince-fugnitto