Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align sidepanel widget contents with header title #4622

Closed
jbicker opened this issue Mar 20, 2019 · 0 comments
Closed

Align sidepanel widget contents with header title #4622

jbicker opened this issue Mar 20, 2019 · 0 comments
Assignees
Labels
ui/ux issues related to user interface / user experience

Comments

@jbicker
Copy link
Contributor

jbicker commented Mar 20, 2019

Left side of contents in sidepanel widgets need to be aligned with the header title.

@jbicker jbicker added the ui/ux issues related to user interface / user experience label Mar 20, 2019
@jbicker jbicker self-assigned this Mar 20, 2019
@jbicker jbicker changed the title Adjust sidepanel widget contents with header title Align sidepanel widget contents with header title Mar 20, 2019
jbicker added a commit that referenced this issue Mar 20, 2019
Fixes #4622

Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
jbicker added a commit that referenced this issue Mar 20, 2019
Fixes #4622

Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
jbicker added a commit that referenced this issue Mar 21, 2019
Fixes #4622

Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
jbicker added a commit that referenced this issue Mar 21, 2019
Fixes #4622

Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
jbicker added a commit that referenced this issue Mar 21, 2019
Fixes #4622

Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
yaweiw added a commit to yaweiw/theia that referenced this issue Apr 9, 2019
* eclipse-theiaGH-4585: Fixed the selection state issue.

From now on, the nodes are remapped from the `tree`,
to ensure the `selection` and `focus` represents the most recent state.
This fix ensures that the selection state does not get out of sync.

Closes eclipse-theia#4585.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>

* Proceed runInTermianl request in a sidecar container

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Initial commit to add 'Run Selected Text' functionality. Signed-off-by: Joshua Bradley <jgbradley1@gmail.com>

Signed-off-by: Josh Bradley <jgbradley1@gmail.com>

* Open new terminal if none exist

Signed-off-by: Joshua Bradley <jgbradley1@gmail.com>

* Simplified getText() with cleaner code

Signed-off-by: Joshua Bradley <jgbradley1@gmail.com>

* Improved text selection behavior

Signed-off-by: Joshua Bradley <jgbradley1@gmail.com>

* Use all the type hierarchy levels the server sends (fixes eclipse-theia#4540)

Signed-off-by: Nathan Ridge <zeratul976@hotmail.com>

* Implemented Toolbar support for sidepanels and changed sidepanel tabs.

Every sidepanel has an header now where the title and a toolbar
is shown (if tools are registered for that widget).
As an example the control buttons of search in workspace extension are
moved to the toolbar.

Additionally the tabs of sidebars  don't show labels anymore but icons.

Fixes eclipse-theia#3864

Signed-off-by: Jan Bicker <jan.bicker@typefox.io>

* [plugin] use the native toolbar for view container

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* [plugin] render view container icon

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* [workspace] add spliceRoots

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* [plugin] fix eclipse-theia#4240: implement workspace.updateWorkspaceFolders

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* [preference] fix parsing of settings from workspace files

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* Make the diff navigation header static

Fixes eclipse-theia#3456

Updated the `git diff` navigation header to be static (fixed).
Currently when there are a lot of changes present in the files changed
list, we lose the header when scrolling. This means that the navigation and
information present in the header is lost so users must always scroll
to the top to access them. This change addresses that issue by providing a
new css class and overflowing only the files changed list to be scrollable.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* Fix eclipse-theia#4595: 'Reveal in Files' error

Signed-off-by: Feng Qingxue <948699357@qq.com>

* Set the minimum perfect scrollbar length

Fixes eclipse-theia#2788

Set the minimum perfect scrollbar length with the `minScrollbarLength`
scrollbar option. Currently in Theia, when there is a lot of vertical
height the scrollbar becomes quite small and hard to use. With this
change we define a minimum length for the scrollbar so it always
remains easily visible for users.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* Make keybinding widget search static

Fixes eclipse-theia#3037

Updated the keybindings widget search bar to be static (fixed in place)
This makes it a lot easier for users to search the table, without the
need to constantly scroll up to re-search.

- Fixed minor typos found in variable names.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* Adjust open workspace explorer button alignment

Adjust the `Open Workspace` button present in the explorer
when no workspace is currently opened. Previously, the alignment
of the button was off (not centered) and after the change
the button was updated to be centered in the widget.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* Fix spelling mistake in block comment

Signed-off-by: Feng Qingxue <948699357@qq.com>

* use VS Code icons in a tabbar toolbar

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* fix eclipse-theia#4633: set git diff title icon

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* Update scrollbar width to a larger value

Minor change to the perfect scrollbar width to
update to a larger value. The change means that
the scrollbar is more accessible, visible and aligns
more with the styling present in VSCode.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* [plugin] fix eclipse-theia#4621: apply only valid configurations as schemas

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* Add missing git diff caption

Fixes eclipse-theia#4639

Currently, the `git-diff-widget` does not have a caption (tooltip).
This means that when the widget is docked, and it's icon is displayed,
no tooltip is shown when hovering while others widget do include it.
For the sake of completeness and consistency, the `git-diff-widget`
should include a caption.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* Involve selection service in tree view on plugin side

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

* Don't let sidepanel titles wrap.

Fixes eclipse-theia#4644

Signed-off-by: Jan Bicker <jan.bicker@typefox.io>

* Added debug console icon

Fixes eclipse-theia#4638

Added debug console icon. The icon selected is the same
as found from the debug widget to open the debug console.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* Aligned widget content in sidepanels to header title.

Fixes eclipse-theia#4622

Signed-off-by: Jan Bicker <jan.bicker@typefox.io>

* [shell] center side bar icons

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* reorder views in side bars to mimic VS Code order

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* Add missing search-in-workspace icon tooltips

Added missing `search-in-workspace` icon tooltips to align with vscode.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* [debug] fix eclipse-theia#4648: preferences to control view, console and location appearance

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* fix eclipse-theia#4658: improve rendering of fa icons in sidebars

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* fix eclipse-theia#4657: use browser preview icon from VS Code for mini-browser preview

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* Added collapse all toolbar item to the explorer

Added a `collapse all` toolbar item to the explorer
used to collapse all nodes from the `navigator-tree`.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* [navigator] don't apply collapse all item to all widgets

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* fix eclipse-theia#4651: apply default configuration overrides properly

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* Fix minor typo in tree.spec.ts

- Fixed minor typo found in `tree.spec.ts`.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* keep properties in definitions of contributed tasks

Task constructor assigns type and id to contributed tasks and removes all the other properties from the task definitions at the same time. This causes Theia not having enough information to proceed when applying customization from tasks.json to the contributed tasks. With this change no properties would be removed from definitions of contributed tasks.

Signed-off-by: elaihau <liang.huang@ericsson.com>

* Set background of webview-icons to 'none'.

Fixes eclipse-theia#4664

Signed-off-by: Jan Bicker <jan.bicker@typefox.io>

* editorconfig: Apply properties to Monaco editor when opening/switching editor

Since commit 260d794 ("[editorconfig] Don't apply all properties on
open"), the editorconfig settings are not applied to the Monaco editor.
For example, if my .editorconfig file says that *.py files should use
tabs with a tab width of 7, I would expect the Monaco editor to be set
to "tab" and a tab width of 7 when I open a .py file.  At the moment,
this does not happen.

The method that applies these properties to the Monaco editor is
applyProperties.  This method is however not called anywhere outside
tests (the commit mentioned above removed the only call).

I have added back the call, such that when an editor is created or the
current editor changes, we apply the settings from the .editorconfig to
the Monaco editor.

I verified that the behavior the commit mentioned above meant to fix is
kept.  That is, no modification is done to the file contents as a result
of just opening the file (or switching to and editor where it is open).
Even if I have "trim_trailing_whitespace = true" in my .editorconfig,
opening the file does not cause the trailing whitespaces to be trimmed.
Pressing ctrl-s, however, does (even if the editor doesn't appear as
"dirty").

Fixes eclipse-theia#4308

Signed-off-by: Simon Marchi <simon.marchi@efficios.com>

* [Styling] various style changes

- bigger tab bars and menu
- use different background colors instead of borders

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>

* [core] disabled expand animation

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>

* fixed typo

Signed-off-by: Thomas Drosdzoll <thomas.drosdzoll@gmx.net>

* typehierarchy shortcut is now ctrlcmd+shift+h

Signed-off-by: Thomas Drosdzoll <thomas.drosdzoll@gmx.net>

* Fix incorrect styling

Fixes eclipse-theia#4678

- Added a new variable to handle the notification-count height
to limit the risk of updating it as a side effect.
- Added a new variable to handle the mini browser toolbar height
to limit the risk of updating it as a side effect.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* [Core UX] Don't close on CTRL+W

Registers event listener which make sure that
window doesn't get closed if CMD/CTRL W is
pressed. Too many users have that in their
muscle memory. Chrome doesn't let us rebind or
prevent default the keybinding, so this at least
doesn't close the window immediately.

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>

* Fix tree node capitalization outside of nav

Fixes eclipse-theia#4692

The PR eclipse-theia#4670 introduced changes which meant that the navigator's file tree's
first node was capitalized among other styling updates. Since other components
use the same `class` `theia-FileTree`, those components were also updated as a
consequence. This PR addresses that issue by making sure only the navigator
gets the new styling by using its `id` instead of the generic class.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* fix eclipse-theia#4661: fix content assist in user preferences

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* [core] Fixed broken wheel listener

Fixes eclipse-theia#4695

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>

* [UX] indicate active widgets on bottom panel

Also fixed some icons not shown in main tab bars.

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>

* [shell] fix eclipse-theia#4697: reset prevent close on keyup and beforeunload

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* Add preferences to handle clang-tidy functionality when clangd v9+ is used.

Fixes issue eclipse-theia#4579
This is a new linter for C/C++. There are two ways to initiate the linter:
  - From the preferences
  - Adding a new file located in the same folder of the files or a parent folder: .clang-tidy

Signed-off-by: Jacques Bouthillier <jacques.bouthillier@ericsson.com>

* Add line numbers to search-in-workspace results

Added line numbers to the `search-in-workspace` results, which
are added through a preference. This enables users to easily
view which line the results are found with the already included
file name and short excerpt of line.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* added tests for interfaces Tree, TreeExpansionService

Signed-off-by: Thomas Drosdzoll <thomas.drosdzoll@gmx.net>

test greening

Signed-off-by: Thomas Drosdzoll <thomas.drosdzoll@gmx.net>

fixed minor typo in tree-expansion.spec.ts

Signed-off-by: Thomas Drosdzoll <thomas.drosdzoll@gmx.net>

* fix eclipse-theia#3674: fix ToolbarAwareTabBar detachment

Detachment should rollback what attachment does, not remove nodes created in the constructor.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* Promise.reject uses Error instead of strings

Signed-off-by: Thomas Drosdzoll <thomas.drosdzoll@gmx.net>

added new to Error instation

* Update file-icons in sidepanels to not have backgrounds

Fixes eclipse-theia#4704

- `file-icons` present in the sidebars (when an editor is docked on either side)
and are inactive, an odd background box is displayed. This background property
is used by other types of icons (mostly svg) so they have the proper color. In
the case of `file-icons` it is enough to simply not apply this background styling.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* make sidebar widgets closable

Signed-off-by: Uni Sayo <unibtc@gmail.com>

* Add files.associations property

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Update callhierarchy tree styling

Fixes eclipse-theia#4643

- update the `callhierarchy` tree styling when resizing.
favor the display of the `symbol` when resizing.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* Update readme screenshot

Fixes eclipse-theia#4635

- Updated the readme screenshot to reflect the recent changes to the user interface.
- Use the absolute path instead of relative for the screenshot source.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* Improved performance for the file rename action

When a file or a folder is renamed from the context menu, if the overwrite flag is set to false, the rename is performed (by the mv library) by copying the source to the target and then deleting the source. If the source file or folder is large, this process may take a long time during which the user is shown the two folders.

Since the renaming action already checks that no file or folder with the target name exists, it's safe to set the overwrite flag to true.

Signed-off-by: Federico Bozzini <federico.bozzini@gmail.com>

* Add missing licenses

Fixes eclipse-theia#4718

In order to help with the IP scan performed by the Eclipse Foundation, it
would help to add license info in each `package.json`. This PR addresses
the `package.json` which do not currently have licenses.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* .gitignore plugins folder

The default location for the plugins folder is in the sources, but it is
currently not ignored.

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>

* Don't redeploy already initialized plugins

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix adding files.associations property

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* set core.toggale.bottom.panel's priority to -1000

do not allow <= 0 priority in right status bar for plugins

Signed-off-by: Uni Sayo <unibtc@gmail.com>

revert c3d4807, move the 'core.toggle.bottom.panel' to the last item

Signed-off-by: Uni Sayo <unibtc@gmail.com>

revert 9f33a31, set core.toggle.bottom.panel priority to -1000

Signed-off-by: Uni Sayo <unibtc@gmail.com>

* Fix eclipse-theia#4740

Signed-off-by: Feng Qingxue <948699357@qq.com>

* Bump VS Code API version

Change-Id: Ifb5f82e0f914a47ba2b0cbc7529452a9a0c68287
Signed-off-by: Florent Benoit <fbenoit@redhat.com>

* Added NOTICE.md file

This file is mandated by the Foundation. For the most part it's auto-
generated. Exception: the "Electron" section towards the end has been
manually added, as requested in CQ #19253, comment eclipse-theia#17.

To eventually update this file, See the Eclipse Theia project page,
navigate to the "Legal Documentation Generator" and look for "NOTICE
FILE".

Today the direct URL is:
https://www.eclipse.org/projects/tools/documentation.php?id=ecd.theia

Make sure to preserve the manually added "Electron" section
at the end.

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>

* Update the explorer to handle multiple-root workspaces

Currently the explorer applies styling for the first
child node (workspace root) but this does not work
in the context of a multiple-root workspace. When in a multiple
root workspace add a root node which simply describes the workspace
name and aligns with vscode.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* change dependency vscode-nsfw to Axosoft/nsfw

- resolves eclipse-theia#4105

Signed-off-by: elaihau <liang.huang@ericsson.com>

* Added LanguageConfiguration (comments, brackets, pairs) for Perl

Signed-off-by: Toon Van Dooren <toon_vd@live.com>

* Update CHANGELOG for 0.5.0 release

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* publish v0.5.0

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>

* fix eclipse-theia#4088: Add 'Upload Files...' menu entries

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* [tree] fix handling global selection

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* fix eclipse-theia#2566: report fs events for real paths

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* eclipse-che/che-theia#103 fix 'getTask' method

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* Publish typedoc to github pages on deploy

Change-Id: I3cef27ba76804cd3194ed81c2d343be9ad9e0282
Signed-off-by: Florent Benoit <fbenoit@redhat.com>

* fix eclipse-theia#4524 add files.enableTrash preference

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* fix 4334: allow to override default preference values for application

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* allow promises on validate.  fix inconsistent selection, add CHANGELOG

This allow creation of files and folders recursive path.
improve validation check, add cancellationtoken

separate validation for absolutpath and leading/trailing spaces

Signed-off-by: Uni Sayo <unibtc@gmail.com>

* fix eclipse-theia#4776: turn off autoSave by deafult

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* Set a minWidth and minHeight in frontend-generator for electron app.

Signed-off-by: jbicker <jan.bicker@typefox.io>

* Allow to choose through CLI the VS Code API version that is provided by vscode.version call in a VS Code extension

$ yarn run start --vscode-api-version=1.40

(and you'll get 1.40 as API version)

note: default value is displayed in help as well

Change-Id: I371e3b008f8d9a8bbd9e047dada4f75e1137e17a
Signed-off-by: Florent Benoit <fbenoit@redhat.com>

* Use external absolute link for logo

It's useful when embedding README in other pages (usecase = the typedoc)
So the logo is displayed nicely.

Change-Id: Ic1063d972d13eb52bef1248ccf869e3ec0e01f23
Signed-off-by: Florent Benoit <fbenoit@redhat.com>

* Add ability to configure task

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

* remove docs script in each package as we now have the root documentation that is generating the typedoc for the whole modules

Change-Id: I0c47554e1a99e22c7b519c94afa7cfd9be1622a4
Signed-off-by: Florent Benoit <fbenoit@redhat.com>

* [file-search] fix eclipse-theia#4599: don't mess around with given include patterns

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* [file-search] excludePatterns without magic

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* [filesystem] Fixes eclipse-theia#4792 XSS vulnerability.

Mitigates the issue by removing all unsanitized information from the
response.

Signed-off-by: Casey Flynn <caseyflynn@google.com>

* Don't rewrite debug capabilities

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>

* Check whether selected item in dialog is non-leaf node

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

* set minimum value for lineHeight and fontSize and align it with VS Code

Signed-off-by: Uni Sayo <unibtc@gmail.com>

* Fix incorrect method name for registerReferenceProvider

Fix typo in `registerReferenceProvider` Plug-in API.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* Add CodeActionKind intersects() Plugin API

Added the Plugin API for `CodeActionKind` `intersects(other: CodeActionKind)` method.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* fix eclipse-theia#4459: register text decoration key in proper service

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* fix gotodefinition failure when editor in preview mode

this path add preview option to EditorOpenerOptions according to 'editor.enablePreview' preference.
if editor.enablePreview changed to false will pin all prevew widget.

Signed-off-by: yewei <yeweiasia@gmail.com>

* Fix plug-in path selection dialog for hosted instance

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

* Handle copying when source and target destinations are the same

Fixes eclipse-theia#4812

- Fixes an issue when calling `copy` from the filesystem when
the `source` and `target` destinations are the same. Currently,
no check is performed to verify if the paths are different
which leads to `fs-extra` throwing an error.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

* Update electron and node packages

Signed-off-by: Rob Moran <rob.moran@arm.com>

* update gitpod to use node 10

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* Remove no longer used interfaces from java-protocol.ts

This is a follow-up ot eclipse-theia#2574 which moved semantic highlighting interfaces
to a language-agnostic place but left these interfaces behind.

Signed-off-by: Nathan Ridge <zeratul976@hotmail.com>

* [vscode] fix eclipse-theia#4339: focus and reveal webviews properly

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

* Support icons in tail decorators

Signed-off-by: Rob Moran <rob.moran@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

No branches or pull requests

1 participant