-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Eclipse Foundation] use official code-of-conduct #6180
Conversation
884db51
to
500c951
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine to me, only general comment I have is regarding the eclipse foundation logo.
Can we have the dark logo instead (https://www.eclipse.org/artwork/) so it looks better when viewing the file in Github? Currently the eclipse name is in white with a white background.
500c951
to
7d8041c
Compare
@vince-fugnitto good catch - it looked good on Gitpod though :) Logo updated. I used the same trick we have in the README for the Theia logo: added the one you suggested in the |
Do we still want the white logo? |
So you meant the first one from the download page, that has "Eclipse" in black? |
Yes exactly, so we are able to see the logo from Github. |
7d8041c
to
fa59200
Compare
updated |
fa59200
to
4aea397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me! :)
Fixes #5780 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
4aea397
to
32143d3
Compare
Better to use the official code of conduct. I was not sure if I should just point to the one hosted at the foundation or have a copy as well so I did both; the content is copied from the foundation and I added a link to the original document as well. And while there I added a couple of logos too.
Fixes #5780
Signed-off-by: Marc Dumais marc.dumais@ericsson.com