Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eclipse Foundation] use official code-of-conduct #6180

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

marcdumais-work
Copy link
Contributor

Better to use the official code of conduct. I was not sure if I should just point to the one hosted at the foundation or have a copy as well so I did both; the content is copied from the foundation and I added a link to the original document as well. And while there I added a couple of logos too.

Fixes #5780

Signed-off-by: Marc Dumais marc.dumais@ericsson.com

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me, only general comment I have is regarding the eclipse foundation logo.
Can we have the dark logo instead (https://www.eclipse.org/artwork/) so it looks better when viewing the file in Github? Currently the eclipse name is in white with a white background.

Screen Shot 2019-09-12 at 6 01 06 PM

@marcdumais-work
Copy link
Contributor Author

@vince-fugnitto good catch - it looked good on Gitpod though :)

Logo updated. I used the same trick we have in the README for the Theia logo: added the one you suggested in the logo dir in the repo and pointed to it. Since it's served by GitHub, it will only be "found" once this PR is merged

@vince-fugnitto
Copy link
Member

@vince-fugnitto good catch - it looked good on Gitpod though :)

Logo updated. I used the same trick we have in the README for the Theia logo: added the one you suggested in the logo dir in the repo and pointed to it. Since it's served by GitHub, it will only be "found" once this PR is merged

Do we still want the white logo?

Screen Shot 2019-09-12 at 7 17 41 PM

@marcdumais-work
Copy link
Contributor Author

Do we still want the white logo?

So you meant the first one from the download page, that has "Eclipse" in black?

@vince-fugnitto
Copy link
Member

Do we still want the white logo?

So you meant the first one from the download page, that has "Eclipse" in black?

Yes exactly, so we are able to see the logo from Github.

@marcdumais-work
Copy link
Contributor Author

Yes exactly, so we are able to see the logo from Github.

updated

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! :)

Fixes #5780

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Eclipse Foundation] Update CODE_OF_CONDUCT.md
2 participants