[plugin] map dependencies to vscode builtins properly

[svenefftinge]

What it does

The builtin extension from vscode that we hare releasing to npm.js need to have an altered package name because the simple names would conflict. Unfortunately there are a few extensions outthere, that have specified dependencies to these extensions using their original name.

For example, ionide asks for vscode.fsharp while we have vscode.@theia/vscode-built-fsharp

How to test

Use this gitpod snapshot, which has both extensions in the plugins folder already.
Try with and without the change.

Or download those extensions manually and try to reproduce locally.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

Could we override pck name instead if a bult-in extension package is coming from npm, for example here:

theia/packages/plugin-ext-vscode/src/node/plugin-vscode-directory-handler.ts

Line 52 in df1e55a

protected resolveFromNpmTarball(plugin: PluginDeployerEntry): boolean {

then the plugin will have a proper id always, not only during activation dependency check.

[svenefftinge]

That is unfortunately not the only place we read the package.json.
Anyway, I moved the change to the single relevant place.

[akosyakov]

It worked nicely for me.

[7sharp9]

So is this now released?

[akosyakov]

It is only in latest nightly Theia version, in latest stable Theia it will be at the end of month. In Gitpod as soon as we update it to use latest nightly. cc @svenefftinge

[7sharp9]

Ok, Im just eager to keep chipping away at getting ionide to work.