Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-9150: Run SIW when updating the glob fields. #9183

Merged
merged 3 commits into from
Mar 12, 2021
Merged

GH-9150: Run SIW when updating the glob fields. #9183

merged 3 commits into from
Mar 12, 2021

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Mar 11, 2021 •
edited
Loading

What it does

  • From now on, the SIW automatically runs when the user changes the include/exclude fields in the widget. Adding whitespace, or changing the order of the globs is a no-op.
  • This PR also cleans up the keyCode warnings, and
  • deprecates the unfocus* fields and replaces unfocus* with blur*.

Closes #9150.

Please review.

How to test

Try the SIW widget, the search should run when you change the glob fields or press Enter.

Review checklist

Reminder for reviewers

Akos Kitta added 2 commits March 11, 2021 13:48
Added new properties. Deprecated the old ones.
8e9a1cd 
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Got rid of the deprecated keyCode API.
9e90c0b 
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos mentioned this pull request Mar 11, 2021
Closed
eclipse-theiaGH-9150: Run SIW when updating the glob fields.
10ea73c 
Closes eclipse-theia#9150.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves search in workspace issues related to the search-in-workspace labels Mar 11, 2021
vince-fugnitto
vince-fugnitto approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the changes using multiple different scenarios and it works very well 👍

@kittaakos
Copy link
Contributor Author

Thank you for the review.

@kittaakos kittaakos merged commit 52d460f into eclipse-theia:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves search in workspace issues related to the search-in-workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[siw] Typing into the files to include, exclude fields do not re-trigger the search
2 participants
@kittaakos @vince-fugnitto