ExpandedProduct.getFeatures(ROOT_FEATURES) returns over-qualified IDs #3674
Conversation
|
The failing test suggests a good place to improve test for this change. Now that the correct feature ID is used the test fails. I'm just not sure the best way to author the improved test. The requirement is present now, as it should be,, but with a filter, so while we could just remove the not() call, we really should also test that the expected filter is present on the requirement. I'm not sure how best to express that so I'm looking for advice. Or maybe you can complete the changes? I can't get this one test to run in debug mode for me. :-( |
merks
force-pushed
the
pr-product-root-features
branch
from
96c485b
to
b051202
Compare
It returns IVersionedId instances where the ID is that of the installable unit, i.e., with an extra .feature.group suffix, rather than the ID of the feature itself. ExpandedProduct.getFeatures(INCLUDED_FEATURES) returns the correct result. A problem arises from this now because with the 4.31 changes to org.eclipse.equinox.p2.publisher.eclipse.ProductAction to generate filtered requirements for the installMode="root" features, this inconsistency produces invalid requirements, i.e., a requirement on xyz.feature.group.feature.group, which does not exist, rather than on xyz.feature.group.
merks
force-pushed
the
pr-product-root-features
branch
from
b051202
to
6ca7af1
Compare
|
Two failing tests are updated to check for the requirement that was formerly absent now being present though with a filter, including one test that checks the exact value of the filter. |
laeubi
added
the
backport-to-tycho-4.0.x
|
/request-license-review |
License review requests: After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status. Workflow run (with attached summary files): |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
It returns IVersionedId instances where the ID is that of the installable unit, i.e., with an extra .feature.group suffix, rather than the ID of the feature itself.
ExpandedProduct.getFeatures(INCLUDED_FEATURES) returns the correct result. A problem arises from this now because with the 4.31 changes to org.eclipse.equinox.p2.publisher.eclipse.ProductAction to generate filtered requirements for the installMode="root" features, this inconsistency produces invalid requirements, i.e., a requirement on xyz.feature.group.feature.group, which does not exist, rather than on xyz.feature.group.