[tycho-4.0.x] ExpandedProduct.getFeatures(ROOT_FEATURES) returns over-qualified IDs #3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It returns IVersionedId instances where the ID is that of the installable unit, i.e., with an extra .feature.group suffix, rather than the ID of the feature itself. ExpandedProduct.getFeatures(INCLUDED_FEATURES) returns the correct result. A problem arises from this now because with the 4.31 changes to org.eclipse.equinox.p2.publisher.eclipse.ProductAction to generate filtered requirements for the installMode="root" features, this inconsistency produces invalid requirements, i.e., a requirement on xyz.feature.group.feature.group, which does not exist, rather than on xyz.feature.group. (cherry picked from commit 9920425)
Test Results 588 files ±0 588 suites ±0 3h 33m 11s ⏱️ - 4m 29s For more details on these failures, see this check. Results for commit bf417c0. ± Comparison against base commit dcbceb4. |
|
Thank you for backporting! 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintotycho-4.0.x:Questions ?
Please refer to the Backport tool documentation