Postgres testing cleanup #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
|
@BillyYccc this is cool for domain sockets, however this is not supported on OSX (due to docker/for-mac#483) which makes impossible to test on OSX domain sockets which is a blocker for testing domain sockets on OSX. |
|
I know that but it could not be avoided if we test Unix domain socket with Docker on the OS X system, so the domain socket tests are skipped if the server is started by TestContainers on OS X. Or should we deploy a specific database in CI with OS X for this kind of stuff? |
|
cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Rework the Postgres testing