Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix Domain Socket support in ContainerPgRule #708

Closed

Conversation

tsegismont
Copy link
Contributor

Replaces embedded Pg with container testing for Unix domain sockets

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont requested a review from vietj July 2, 2020 17:24
@tsegismont
Copy link
Contributor Author

@vietj can you please take a look and try on your machine? Thank you

@vietj
Copy link
Member

vietj commented Jul 2, 2020

this isn't something we want to do because it cannot be tested on OS X since Docker for Mac is not able to share domain sockets, see docker/for-mac#483

Copy link
Member

@vietj vietj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not work on OS X because Docker for Mac does not support sharing domain sockets, that's the reason we kept this rule

@tsegismont tsegismont added the hold label Jul 3, 2020
@tsegismont
Copy link
Contributor Author

Ok, let's put this on hold then

@vietj
Copy link
Member

vietj commented Jul 3, 2020

yes, that's unfortunate, you can give your +1 on the Docker GitHub issue to make it progress.

@BillyYccc
Copy link
Member

This is in fact duplicated of #520.
I wonder if we could set up a specific database with unix socket in the CI for tests.

@tsegismont
Copy link
Contributor Author

Ha, I had not noticed @BillyYccc , sorry.

@vietj on second thoughts, do we absolutely need an automated test for BSD and the likes? There is nothing specific in our code, we just pull a different dependency. And CI validates it works on Linux.

What are the chances something goes wrong with kqueue specifically? And if we get a bug report, there is still the option to start a server installed from brew and test manually in the background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants