Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language_pack is outdated? #501

Closed
jonahgraham opened this issue Mar 8, 2023 · 1 comment
Closed

language_pack is outdated? #501

jonahgraham opened this issue Mar 8, 2023 · 1 comment

Comments

@jonahgraham
Copy link

While working on #500 I had to regenerate the language_pack. There are lots of differences between the current git HEAD and what is generated in the update directory.

Is this supposed to be done on a regular basis? How do we validate such changes?

I will provide a PR that does the update, but it isn't validated.
jonahgraham added a commit to jonahgraham/tm4e that referenced this issue Mar 8, 2023
@jonahgraham
Regenate language_pack
dc1ef40 
This was done by running `mvn package` in `_update`.
And bumping version numbers due to updated language packs

Fixes eclipse#501
jonahgraham added a commit to jonahgraham/tm4e that referenced this issue Mar 8, 2023
@jonahgraham
Regenerate language_pack
9edb497 
This was done by running `mvn package` in `_update`.
And bumping version numbers due to updated language packs

Fixes eclipse#501
This was referenced Mar 8, 2023
Closed
Open
jonahgraham added a commit to jonahgraham/tm4e that referenced this issue Mar 8, 2023
@jonahgraham
Regenerate language_pack
24c5e09 
This was done by running `mvn package` in `_update`.

The autogenerated files have one small error that was
previously fixed in 242dcf1
and this change therefore preserves that fix by excluding this
diff from the commit:

```diff
diff --git a/org.eclipse.tm4e.language_pack/javascript/Regular Expressions (JavaScript).tmLanguage b/org.eclipse.tm4e.language_pack/javascript/Regular Expressions (JavaScript).tmLanguage
index 54c7651c..1dda7806 100644
--- a/org.eclipse.tm4e.language_pack/javascript/Regular Expressions (JavaScript).tmLanguage
+++ b/org.eclipse.tm4e.language_pack/javascript/Regular Expressions (JavaScript).tmLanguage
@@ -230,7 +230,7 @@
                </dict>
        </dict>
        <key>scopeName</key>
-       <string>lngpck.source.js.regexp</string>
+       <string>source.js.regexp</string>
        <key>uuid</key>
        <string>AC8679DE-3AC7-4056-84F9-69A7ADC29DDD</string>
 </dict>
```

And bumping version numbers due to updated language packs

Fixes eclipse#501
@sebthom sebthom mentioned this issue Jun 11, 2023
Merged
@sebthom
Copy link
Member

sebthom commented Jun 12, 2023

Addressed by #550

@sebthom sebthom closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Regenerate language_pack jonahgraham/tm4e
2 participants
@sebthom @jonahgraham