This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Change number of pixels used by datashader #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example plots o96 - https://mlflow.ecmwf.int/#/experiments/5/runs/000304c17e304ac9bc353a7d0931d884/artifacts |
Merged
HCookie
previously approved these changes
Nov 22, 2024
|
Has this been tested at a few resolutions? |
4 tasks
Worked with @JPXKQX on this and should be now working fine for LAM |
HCookie
approved these changes
Nov 27, 2024
HCookie
changed the title
HCookie
deleted the
150-n320-callback-number-of-pixels-used-by-datashader
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix #150
Propose change - make the 'n_pixels' more flexible so that when using finer resolutions (like n32), 500 as
n_pixelsshould be enough, but for hidden grid plots and coarser ones then we need to use way less, so the other condition would apply.Note - Regarding the proposed change
n_pixels = min(int(np.floor(data.shape[0] * 0.004)), 500). This has been found by testing different values, so it's fair to say that 0.04% could be better tweaked in the future if needed.This PR also includes contributions from @mpvginde who developed the code to ensure common color map ranges
Closes #150