Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates based on changes to EnrollmentService #7

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

ziafazal
Copy link
Contributor

This PR has these changes

  1. Repalce pkg_resources with importlib_resources
  2. User django_user_id ins enrollment service instead of django_user
  3. Comment out IFRMAE related fields for now since we are not supporting cmi5 content in iframe for now

Copy link

@Abdul-Muqadim-Arbisoft Abdul-Muqadim-Arbisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also modify ci to have checks for both python 3.8 and 3.12 in ci.yml file, similar to this PR

Copy link

@Abdul-Muqadim-Arbisoft Abdul-Muqadim-Arbisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@ziafazal ziafazal merged commit 587fe0d into master Mar 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants