feat: upgrade to 12 first attempt resolve #31 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghassanmas
force-pushed
the
python-12
branch
from
835dc0f
to
bcb83b7
Compare
|
Yes, those 3.8 type issues are a this is a known mypy problem: overhangio/tutor#956 |
|
@ghassanmas Hi, You can use something like overhangio/cookiecutter-tutor-plugin#31 to have checks for both 3.8 and 3.12. The current config only runs CI on one version, as far as I understand. |
|
@DawoudSheraz yeah right I just update it. I think this is ready now for review. CC: @regisb |
| @@ -0,0 +1 @@ | |||
| [[Feature]] Upgrade Python version to 3.12 (by @ghassanmas) | |||
There was a problem hiding this comment.
Since it is CI level change only, its not really a feature. Plus, we dont need the changelogs for CI-only changes.
There was a problem hiding this comment.
@ghassanmas FYI, let's remove this changelog and get the PR merged. Thanks
There was a problem hiding this comment.
Done, sorru I though it was okay since the PR was approved.
DawoudSheraz
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currenlty I ran out of
mypytest issues but those occurs even on python 3.8( I just had to update pip)I turn tutor and tutor-forum and locally though it doesn't python service
Note: locally I got the above error, and this/last CI/CD runs python12