Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend-build updated to v12 #277

Merged
merged 15 commits into from
Dec 1, 2022

Conversation

BilalQamar95
Copy link
Contributor

Ticket:
42: Upgrade eslint to v8.x

What changed?

  • Updated frontend-build to v12 (Eslint was updated in frontend-build version resulting in it's version being bumped to v12. This PR updates frontend-build to reciprocate eslint version update)
  • Resolved eslint issues post update

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #277 (a81dcd8) into master (f97a311) will increase coverage by 0.71%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   59.13%   59.85%   +0.71%     
==========================================
  Files          14       14              
  Lines         279      279              
  Branches       67       67              
==========================================
+ Hits          165      167       +2     
+ Misses        113      111       -2     
  Partials        1        1              
Impacted Files Coverage Δ
src/Avatar.jsx 0.00% <0.00%> (ø)
src/learning-header/AnonymousUserMenu.jsx 66.66% <50.00%> (+33.33%) ⬆️
src/Header.jsx 91.17% <100.00%> (ø)
src/Icons.jsx 66.66% <100.00%> (ø)
src/Logo.jsx 100.00% <100.00%> (ø)
src/Menu/Menu.jsx 30.70% <100.00%> (+0.47%) ⬆️
src/learning-header/AuthenticatedUserDropdown.jsx 88.88% <100.00%> (ø)
src/learning-header/LearningHeader.jsx 88.23% <100.00%> (+0.73%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BilalQamar95 BilalQamar95 merged commit 403db9f into master Dec 1, 2022
@BilalQamar95 BilalQamar95 deleted the bilalqamar95/frontend-build-upgrade branch December 1, 2022 10:08
BilalQamar95 added a commit that referenced this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants