Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint to v8.x #42

Closed
18 of 27 tasks
Tracked by #688
davidjoy opened this issue Nov 22, 2021 · 4 comments
Closed
18 of 27 tasks
Tracked by #688

Upgrade eslint to v8.x #42

davidjoy opened this issue Nov 22, 2021 · 4 comments
Assignees

Comments

@davidjoy
Copy link
Contributor

davidjoy commented Nov 22, 2021

We're currently using eslint v6.x. We'd like to upgrade this to the latest stable release v8.x.

We should be able to do this without creating any new linting errors, hopefully.

Also, it's worth noting that automated updates in https://github.com/edx/eslint-config updated our version of eslint there to 7.x. These dependencies are only used in development of the eslint-config, as it declares them as peer dependencies. https://github.com/edx/frontend-build defines the actual eslint dependencies we use, which use v6.x. So, despite our config being on v7, everything else is still on v6.x and (luckily) nothing has broken. We should straighten out this situation when doing this upgrade.

PRs

Base

Components

MFEs

Enterprise

@jmbowman jmbowman moved this to Todo in FED-BOM May 26, 2022
@jmbowman jmbowman added this to FED-BOM May 26, 2022
@BilalQamar95 BilalQamar95 self-assigned this Jun 16, 2022
@BilalQamar95 BilalQamar95 moved this from Todo to In Progress in FED-BOM Jun 20, 2022
@arbrandes
Copy link

@BilalQamar95, sprint check: we're just waiting for reviews/merges, correct?

@BilalQamar95
Copy link

@arbrandes Yes, these are waiting for reviews/merges

@arbrandes
Copy link

@BilalQamar95, are we done here?

@BilalQamar95
Copy link

@BilalQamar95, are we done here?

Yes, seems concluded.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Maintenance (deprecated version) May 31, 2023
@github-project-automation github-project-automation bot moved this from Author Team Review to Done in FED-BOM May 31, 2023
@github-project-automation github-project-automation bot moved this from In review to Closed in Frontend Working Group May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

No branches or pull requests

3 participants