Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ParseBindPath from config Get/Setters & add basic tests, from sylabs 319 #15

Closed
wants to merge 10 commits into from

Conversation

edytuk
Copy link
Owner

@edytuk edytuk commented Nov 4, 2021

This pulls in sylabs PR

The original PR description was:

The parsing routines for bind mount specifications are buried among a large amount of simple Getter/Setter code for the main config struct within pkg/runtime/engine/singularity/config. There are also no unit tests on the parsing, and it's a little under-described.

In advance of sylabs/singularity#118 work, split the parsing functions into a separate file for clarity, and add basic testing. Add a couple of comments, and constants to make things a bit clearer. No real logic changes here - code was just moved.

@edytuk edytuk closed this Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants