Skip to content

Commit

Permalink
#43 Move approve command under token commands
Browse files Browse the repository at this point in the history
  • Loading branch information
andreafspeziale authored and ceres3idoo committed Feb 28, 2019
1 parent b35b0cd commit 62d120a
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 8 deletions.
11 changes: 7 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,14 @@ Release date: 2019-02-REPLEACE_ME.
- [CLI approve command](https://github.com/eidoo/hybrid-exchange-sdk/issues/18)
- [CLI withdraw command](https://github.com/eidoo/hybrid-exchange-sdk/issues/13)
- [Deposit Token with approve](https://github.com/eidoo/hybrid-exchange-sdk/issues/11)
- [Allowance](https://github.com/eidoo/hybrid-exchange-sdk/issues/7).
- [Private key from mnemonic](https://github.com/eidoo/hybrid-exchange-sdk/issues/5).
- [Pair fee](https://github.com/eidoo/hybrid-exchange-sdk/issues/1).
- [Pair last price](https://github.com/eidoo/hybrid-exchange-sdk/issues/3).
- [Allowance](https://github.com/eidoo/hybrid-exchange-sdk/issues/7)
- [Private key from mnemonic](https://github.com/eidoo/hybrid-exchange-sdk/issues/5)
- [Pair fee](https://github.com/eidoo/hybrid-exchange-sdk/issues/1)
- [Pair last price](https://github.com/eidoo/hybrid-exchange-sdk/issues/3)

### Changed

- [Approve command](https://github.com/eidoo/hybrid-exchange-sdk/issues/43)

## [v1.1.0](https://gitlab.com/eidoo_io/hybrid-exchange-sdk/compare/fa85a7...v1.1.0)

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion src/commands/commandList.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const ApproveCommandBuilder = require('../factories/commands/trading-wallet/ApproveCommandBuilder')
const ApproveCommandBuilder = require('../factories/commands/token/ApproveCommandBuilder')
const CreateWalletCommandBuilder = require('../factories/commands/trading-wallet/CreateWalletCommandBuilder')
const DepositEthCommandBuilder = require('../factories/commands/trading-wallet/DepositEthCommandBuilder')
const DepositTokenCommandBuilder = require('../factories/commands/trading-wallet/DepositTokenCommandBuilder')
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion src/commands/token/GetAllowanceCommand.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class GetAllowanceCommand extends ABaseCommand {

if (privateKeyFilePath) {
const privateKey = await this.extractPrivateKey(privateKeyFilePath)
ownerAddressRetrived = this.getAddressOromPrivateKey(owner, privateKey)
ownerAddressRetrived = this.getAddressFromPrivateKey(owner, privateKey)
}

if (draft) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const ApproveCommand = require('../../../commands/trading-wallet/ApproveCommand')
const ApproveCommandValidator = require('../../../validators/commands/trading-wallet/ApproveCommandValidator')
const ApproveCommand = require('../../../commands/token/ApproveCommand')
const ApproveCommandValidator = require('../../../validators/commands/token/ApproveCommandValidator')
const { PrivateKeyService } = require('../../../services/PrivateKeyService')
const PrivateKeyValidator = require('../../../validators/PrivateKeyValidator')

Expand Down

0 comments on commit 62d120a

Please sign in to comment.