Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor moving approve command under token commands #43

Closed
andreafspeziale opened this issue Feb 27, 2019 · 0 comments
Closed

Refactor moving approve command under token commands #43

andreafspeziale opened this issue Feb 27, 2019 · 0 comments
Assignees
@ceres3idoo
Labels
Refactor Refactoring code
Milestone
CLI v1.0

Comments

@andreafspeziale
Copy link
Contributor

📝 Refactor

The approve command is under trading wallet commands right know. Make it more generic and move it under the token commands.
@andreafspeziale andreafspeziale added the Refactor Refactoring code label Feb 27, 2019
@andreafspeziale andreafspeziale added this to the CLI v1.0 milestone Feb 27, 2019
@andreafspeziale andreafspeziale self-assigned this Feb 27, 2019
andreafspeziale added a commit that referenced this issue Feb 28, 2019
@andreafspeziale
#43 Move approve command controller under token commands
e79a519
andreafspeziale added a commit that referenced this issue Feb 28, 2019
@andreafspeziale
#43 Move approve command builder under token command builders
16f1f66
andreafspeziale added a commit that referenced this issue Feb 28, 2019
@andreafspeziale
#43 Update approve command builder import
4e2cf05
andreafspeziale added a commit that referenced this issue Feb 28, 2019
@andreafspeziale
#43 Move approve command validator to token command validators
d8cd295
andreafspeziale added a commit that referenced this issue Feb 28, 2019
@andreafspeziale
#43 Move approve command definition under token commands definition
0694781
andreafspeziale added a commit that referenced this issue Feb 28, 2019
@andreafspeziale
#43 Update CHANGELOG
e19e95a
@andreafspeziale andreafspeziale mentioned this issue Feb 28, 2019
Merged
andreafspeziale added a commit that referenced this issue Feb 28, 2019
@andreafspeziale
#43 GetAllowanceCommand bug fix
bf7732f
@andreafspeziale andreafspeziale removed their assignment Feb 28, 2019
@ceres3idoo ceres3idoo self-assigned this Feb 28, 2019
ceres3idoo pushed a commit that referenced this issue Feb 28, 2019
@andreafspeziale @ceres3idoo
#43 Move approve command under token commands
62d120a
@andreafspeziale andreafspeziale modified the milestones: CLI v1.1, CLI v1.0 Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceres3idoo ceres3idoo

Labels
Refactor Refactoring code
Projects
None yet
Milestone
CLI v1.0
Development

No branches or pull requests
2 participants
@andreafspeziale @ceres3idoo