fix(metrics): bump opentelemetry dependencies #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These contain a breaking change we had to account for and it is usually best to bump them together.
This metric is now included in the otelgrpc opentelemetry contrib package. A side effect of this is that we loose the status code attr. Status on this can be tracked here: open-telemetry/opentelemetry-go-contrib#2840
ericwenn
approved these changes
Feb 7, 2023
This was referenced Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These contain a breaking change we had to account for and it is usually best to bump them together.
The pubsub message was updated due to the old being deprecated. This is the new recommended proto to use.
We also remove the
server.rpc.durationmetric due to it now being included in the otelgrpc opentelemetry contrib package. A side effect of this is that we loose the status code attr.Status on this metric can be tracked here