fix(metrics): bump opentelemetry dependenncies #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move server.rpc.duration metric to server.rpc.duration_deprecated, as it is now included in the otelgrpc opentelemetry contrib package. A side effect of this is that we loose the status code attr. Status on this can be tracked here: open-telemetry/opentelemetry-go-contrib#2840
|
Why keep the previous metric under new name? |
|
I want to compare whether they have differences as we have some alerts is using it and filtering on grpc status code and so on. If there does have some differences and we have difficulties switching the alerts, we might want to switch back to our internal one for a while, and perhaps able to update the implementation on their side. |
ericwenn
approved these changes
Feb 18, 2023
|
|
|
The problem still exists...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move server.rpc.duration metric to server.rpc.duration_deprecated, as it is now included in the otelgrpc opentelemetry contrib package. A side effect of this is that we loose the status code attr.
Status on this can be tracked here:
open-telemetry/opentelemetry-go-contrib#2840
Basically, do this reverted #382 again as there has been a fix for the memory (infinite loop) issue GoogleCloudPlatform/opentelemetry-operations-go#591
But we keep
rpc.server.duration_deprecatedmetric for now and remove it later. Also allowing a comparison of our own metric implementation vs the opentelemetry-go-contrib implementation