Skip to content

Commit

Permalink
fix: dont reset counters & durations after each scrape (#216)
Browse files Browse the repository at this point in the history
prom counters are _up_ only. we should not be resetting them after each
scrape.

duration histograms are also designed to accumulate information over
time, they should not need to be reset either.

fixes: elastic-ipfs/elastic-ipfs#35

License: MIT

Signed-off-by: Oli Evans <oli@protocol.ai>
  • Loading branch information
olizilla authored Jul 6, 2023
1 parent 0f0a4a3 commit 4101994
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/http-server.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,7 @@ class HttpServer {
})
telemetry.export().then(result => {
res.end(result)
telemetry.resetCounters()
telemetry.resetDurations()
}
)
})
break
}
default:
Expand Down

0 comments on commit 4101994

Please sign in to comment.