fix: dont reset counters & durations after each scrape #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prom counters are _up_ only. we should not be resetting them after each scrape. duration histograms are also designed to accumulate information over time, they should not need to be reset either. fixes: elastic-ipfs/elastic-ipfs#35 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
alanshaw
approved these changes
Jul 6, 2023
olizilla
added a commit
to elastic-ipfs/bitswap-peer-deployment
that referenced
this pull request
Jul 6, 2023
see: elastic-ipfs/bitswap-peer#216 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
olizilla
added a commit
to elastic-ipfs/bitswap-peer-deployment
that referenced
this pull request
Jul 6, 2023
see: elastic-ipfs/bitswap-peer#216 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
|
Counters now go up! |
olizilla
added a commit
to elastic-ipfs/bitswap-peer-deployment
that referenced
this pull request
Jul 6, 2023
see: elastic-ipfs/bitswap-peer#216 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prom counters are up only. we should not be resetting them after each scrape.
duration histograms are also designed to accumulate information over time, they should not need to be reset either.
fixes: elastic-ipfs/elastic-ipfs#35
License: MIT