Fix empty flushed=True request for forced flushes #1628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
It turns out I never actually tested the functionality for sending an empty request with
flushed=True
when an explicit flush is called with no data on the buffer. The function signature was wrong (😅), and we also can't POST with aNone
body, we need an empty dict for the body.Luckily, it should be rare to hit this issue because we usually flush before we've had a chance to send the contents of the buffer, and that
flushed=True
worked fine.This fixes those issues and adds a test for this explicit case.
Thanks to @josef-cech-acc for catching this.
Related issues
Closes #1627