Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some flaky tests #1631

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Fix some flaky tests #1631

merged 3 commits into from
Sep 15, 2022

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Sep 13, 2022

What does this pull request do?

Fixes a couple of flaky tests since the introduction of #1628

Fixes #1633

@apmmachine
Copy link
Contributor

apmmachine commented Sep 13, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-14T18:12:46.638+0000

  • Duration: 31 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 4979
Skipped 3338
Total 8317

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Sep 13, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (66/66) 💚
Files 100.0% (225/225) 💚
Classes 100.0% (225/225) 💚
Lines 89.808% (17464/19446) 👎 -0.008
Conditionals 77.133% (3191/4137) 👍

@basepi
Copy link
Contributor Author

basepi commented Sep 13, 2022

/test full

tests/client/client_tests.py Outdated Show resolved Hide resolved
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@basepi basepi merged commit f76eb23 into elastic:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants