Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring: enable tracing self instrumentation in APM Server #14231

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

1pkg
Copy link
Member

@1pkg 1pkg commented Oct 2, 2024

Motivation/summary

This PR addresses the issue #14230 and enables self instrumentation in APM Server.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

For the detailed steps to test this changes in self-hosted APM Server refer to #13514 (comment)

Related issues

#14230

@1pkg 1pkg requested a review from a team as a code owner October 2, 2024 00:52
Copy link
Contributor

mergify bot commented Oct 2, 2024

This pull request does not have a backport label. Could you fix it @1pkg? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Oct 2, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 2, 2024
@1pkg 1pkg force-pushed the enable-self-instrumentation-tracing branch from 0c20c25 to b5fc9c5 Compare October 2, 2024 00:53
@1pkg 1pkg self-assigned this Oct 2, 2024
@1pkg 1pkg changed the title Enable tracing self instrumentation in APM Server Monitoring: enable tracing self instrumentation in APM Server Oct 3, 2024
@1pkg 1pkg changed the title Monitoring: enable tracing self instrumentation in APM Server monitoring: enable tracing self instrumentation in APM Server Oct 3, 2024
Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change needs a changelog entry

@1pkg 1pkg force-pushed the enable-self-instrumentation-tracing branch from cc8e20d to 473977a Compare October 4, 2024 01:16
changelogs/head.asciidoc Outdated Show resolved Hide resolved
@1pkg
Copy link
Member Author

1pkg commented Oct 5, 2024

While testing the changes manually, I discovered a bug in EA tracing sampling changes where sampling_rate is formatted as a binary (hex) with exponent instead of decimal literal without exponent, this breaks subsequent call in apm-agent-go when tracer is initialized with a custom sampling rate.

image

@1pkg
Copy link
Member Author

1pkg commented Oct 5, 2024

Raised an issue in the agent repo elastic/elastic-agent#5711

@1pkg 1pkg requested review from axw and marclop October 12, 2024 00:07
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @1pkg!

@1pkg
Copy link
Member Author

1pkg commented Oct 14, 2024

Can't be merged yet due to the Cloud configuration missing sensible default for sampling_rate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants