Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APMConfig SamplingRate binary float formatting breaks apm-agent-go tracer instrumentation #5711

Closed
1pkg opened this issue Oct 5, 2024 · 1 comment · Fixed by #5712
Closed
Assignees
Labels
bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@1pkg
Copy link
Member

1pkg commented Oct 5, 2024

Description

The changes to support configurable sampling rate for APMConfig in elastic/elastic-agent-client#123 seem to now work as expected. During the course of integrating the change to APM Server in PR, I discovered that sampling_rate is formatted as a binary (hex) with exponent instead of decimal literal without exponent, this breaks subsequent call in apm-agent-go when tracer is initialized via ELASTIC_APM_TRANSACTION_SAMPLE_RATE with a custom sampling rate.

A quick stripped down go playground snippet with the problem.

Steps to Reproduce

On the latest agent build set non empty value to agent.monitoring.apm.sampling_rate for example "0.1".

Image

Related Issues

@1pkg 1pkg added the bug Something isn't working label Oct 5, 2024
@pchila pchila self-assigned this Oct 7, 2024
@pchila pchila added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants