Feature/improve tests syntax (#35667) (#35701)

* feature/improve-tests-syntax, update increment * feature/improve-tests-syntax, update increment * feature/improve-tests-syntax, update increment * feature/improve-tests-syntax, improve changelog * feature/feature/improve-tests-syntax, add summary to proper changelog file (cherry picked from commit 949d713) Co-authored-by: bgvladedivac <bgvladedivac@gmail.com>
elastic · Jun 7, 2023 · 599bec0 · 599bec0
1 parent 63032ce
commit 599bec0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG-developer.next.asciidoc b/CHANGELOG-developer.next.asciidoc
@@ -143,6 +143,7 @@ The list below covers the major changes between 7.0.0-rc2 and main only.
 - Add support for `credentials_json` in `gcp` module, all metricsets {pull}29584[29584]
 - Add gcp firestore metricset. {pull}29918[29918]
 - Added TESTING_FILEBEAT_FILEPATTERN option for filebeat module pytests {pull}30103[30103]
+- Improve tests files with shorter statements. {pull}35667[35667]
 - Add gcp dataproc metricset. {pull}30008[30008]
 - Add Github action for linting
 - Add regex support for drop_fields processor.

diff --git a/filebeat/tests/load/load.py b/filebeat/tests/load/load.py
@@ -34,5 +34,5 @@
     randomString = ''.join(random.choice(string.ascii_uppercase + string.digits) for _ in range(length))
     log_message = timestamp + " " + str(count) + " " + str(uuid.uuid4()) + " " + randomString
     my_logger.debug(log_message)
-    count = count + 1
+    count += 1
     time.sleep(sleepTime)
diff --git a/filebeat/tests/open-file-handlers/log_file.py b/filebeat/tests/open-file-handlers/log_file.py
@@ -22,7 +22,7 @@
 while True:
     # for i in range(0, 10000):
     time.sleep(random.uniform(0, 0.1))
-    i = i + 1
+    i += 1
     # Tries to cause some more heavy peaks
     events = random.randrange(10) + 1
     for n in range(events):