Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/improve tests syntax #35667

Merged
merged 8 commits into from
Jun 6, 2023
Merged

Feature/improve tests syntax #35667

merged 8 commits into from
Jun 6, 2023

Conversation

bgvladedivac
Copy link
Contributor

What does this PR do?

A small improvement short handing the assignment and incremental.

Why is it important?

It creates a shorter and more pythonic statement, while maintaining the semantics of it.

Checklist

  • [ x] My code follows the style guidelines of this project
  • [ x] I have made corresponding changes to the documentation
  • [ x] I have made corresponding change to the default configuration files
  • [ x] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@bgvladedivac bgvladedivac requested a review from a team as a code owner June 3, 2023 20:31
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 3, 2023
@cla-checker-service
Copy link

cla-checker-service bot commented Jun 3, 2023 •
edited
Loading

💚 CLA has been signed

@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @bgvladedivac? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@bgvladedivac
Copy link
Contributor Author

Just signed the Contributor agreement.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 3, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-06T12:19:33.354+0000

  • Duration: 48 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 4916
Skipped 576
Total 5492

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert
Copy link
Collaborator

Hello,
Thanks for your suggestion.
Could you please change the changelog to add it to CHANGELOG-developer.next.asciidoc instead?
This change won't be visible for our users so it would be better to have it only for developers.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Jun 5, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 5, 2023
@bgvladedivac
Copy link
Contributor Author

@pierrehilbert just added the change to the proper file.

@cmacknz cmacknz removed the request for review from fearful-symmetry June 5, 2023 19:44
@pierrehilbert pierrehilbert added backport-v8.8.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Jun 6, 2023
@pierrehilbert
Copy link
Collaborator

/test

@pierrehilbert pierrehilbert merged commit 949d713 into elastic:main Jun 6, 2023
@pierrehilbert
Copy link
Collaborator

Thx @bgvladedivac

mergify bot pushed a commit that referenced this pull request Jun 6, 2023
@bgvladedivac @mergify
Feature/improve tests syntax (#35667)
aaf1b02 
* feature/improve-tests-syntax, update increment

* feature/improve-tests-syntax, update increment

* feature/improve-tests-syntax, update increment

* feature/improve-tests-syntax, improve changelog

* feature/feature/improve-tests-syntax, add summary to proper changelog file

(cherry picked from commit 949d713)
@mergify mergify bot mentioned this pull request Jun 6, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jun 6, 2023
@bgvladedivac @mergify
Feature/improve tests syntax (#35667)
601364a 
* feature/improve-tests-syntax, update increment

* feature/improve-tests-syntax, update increment

* feature/improve-tests-syntax, update increment

* feature/improve-tests-syntax, improve changelog

* feature/feature/improve-tests-syntax, add summary to proper changelog file

(cherry picked from commit 949d713)
@mergify mergify bot mentioned this pull request Jun 6, 2023
Merged
pierrehilbert added a commit that referenced this pull request Jun 7, 2023
@mergify @bgvladedivac @pierrehilbert
[7.17](backport #35667) Feature/improve tests syntax (#35700)
c8b1ae8 
* Feature/improve tests syntax (#35667)

* feature/improve-tests-syntax, update increment

* feature/improve-tests-syntax, update increment

* feature/improve-tests-syntax, update increment

* feature/improve-tests-syntax, improve changelog

* feature/feature/improve-tests-syntax, add summary to proper changelog file

(cherry picked from commit 949d713)

* Update CHANGELOG-developer.next.asciidoc

---------

Co-authored-by: bgvladedivac <bgvladedivac@gmail.com>
Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
pierrehilbert pushed a commit that referenced this pull request Jun 7, 2023
@mergify @bgvladedivac
Feature/improve tests syntax (#35667) (#35701)
599bec0 
* feature/improve-tests-syntax, update increment

* feature/improve-tests-syntax, update increment

* feature/improve-tests-syntax, update increment

* feature/improve-tests-syntax, improve changelog

* feature/feature/improve-tests-syntax, add summary to proper changelog file

(cherry picked from commit 949d713)

Co-authored-by: bgvladedivac <bgvladedivac@gmail.com>
@reakaleek reakaleek mentioned this pull request Jul 19, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

Assignees

@bgvladedivac bgvladedivac

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.8.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgvladedivac @elasticmachine @pierrehilbert