Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_kubernetes_metadata processor is broken because it uses old field "source" for lookup #10505

Closed
alakahakai opened this issue Feb 2, 2019 · 5 comments
Closed

add_kubernetes_metadata processor is broken because it uses old field "source" for lookup #10505

alakahakai opened this issue Feb 2, 2019 · 5 comments
Labels
bug containers Related to containers use case Filebeat Filebeat Team:Integrations Label for the Integrations team

Comments

@alakahakai
Copy link

Filebeat add_kubernetes_metadata processor is no longer working, because it still uses old field "source" for matcher, while the source field has been changed to log.file.path by ECS.
@ruflin ruflin added bug Filebeat Filebeat containers Related to containers use case Team:Integrations Label for the Integrations team labels Feb 4, 2019
@ruflin
Copy link
Contributor

ruflin commented Feb 4, 2019

@alakahakai This indeed sounds like a bug. I haven't tested it locally but I see you already have a commit above. Could you open a PR with the fix against the Beats repo?

@ruflin
Copy link
Contributor

ruflin commented Feb 4, 2019

Nevermind, just found this PR: #10506

alakahakai pushed a commit that referenced this issue Feb 4, 2019
Address issue #10505 (add_kubernetes_metadata processor matcher not w…
8b520c5 
…orking) (#10506)

* Address issue #10505 - add_kubernetes_metadata processor is broken because it uses old field source for lookup

* Address issue 10505 - update documentation

* Add pull # to CHANGELOG.asciidoc

* Fix unit test case

* Move update to CHANGELOG.next.asciidoc
@odacremolbap
Copy link
Contributor

@alakahakai @ruflin
can we close this issue?

@ruflin
Copy link
Contributor

ruflin commented Apr 5, 2019

@odacremolbap I assume yes, can you check if all the needed backports happened?

@odacremolbap
Copy link
Contributor

it is
(although it looks like the cherrypick_pr tool was not used, but the code is present at 7.0 and 7.x)

closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug containers Related to containers use case Filebeat Filebeat Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ruflin @alakahakai @odacremolbap