Address issue #10505 (add_kubernetes_metadata processor matcher not working) #10506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alakahakai
changed the title
alakahakai
requested review from
andrewkroh and
tsg
and removed request for
tsg and
andrewkroh
andrewkroh
requested changes
Feb 4, 2019
Good catch. fixed this. |
ruflin
reviewed
Feb 4, 2019
added 5 commits
February 4, 2019 13:21
tsg
reviewed
Feb 4, 2019
|
@alakahakai Thank you for the fix. |
ruflin
reviewed
Mar 29, 2019
| @@ -77,9 +77,9 @@ const containerIdLen = 64 | |||
| const podUIDPos = 5 | |||
|
|
|||
| func (f *LogPathMatcher) MetadataIndex(event common.MapStr) string { | |||
| if value, ok := event["source"]; ok { | |||
| if value, ok := event["log"].(common.MapStr)["file"].(common.MapStr)["path"]; ok { | |||
There was a problem hiding this comment.
This line probably breaks with the redis input as it does not have the fields in here.
There was a problem hiding this comment.
@alakahakai I think using event.Get("log.file.path") should be safe w.r.t. #11543 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_kubernetes_metadata processor is broken because it uses old field source for lookup. Use log.file.path for matcher.