-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CRI-O based logs autodiscover #10687
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Failure looks like a flaky test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vjsamuel for working on this, I think this new path
option will be really helpful, it mostly LGTM.
I think we could maintain both options long-term, I still see ids
as a more straightforward option for docker use cases and we may think on providing new inputs for other runtimes in the future, so I wouldn't think as ids
as deprecated for docker. For this reason I'd also keep the tests for ids
and would add tests for paths.
Try to update the branch with master, I think that at least the ML-related failures are fixed there. |
seems like yet another flaky test case on |
jenkins, test this |
jenkins, test this again please |
@vjsamuel for the followup (or here) could you also mention the new |
Hi, i don't understand the minimum beat version who is compatible CRI-O ? |
Hey @adelbot, this change is available since 7.2.0. |
This PR attempts to do two things: