Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog and add documentation for containers.paths #10864

Merged
merged 3 commits into from
Feb 26, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Feb 21, 2019

Follow up of #10687

@jsoriano jsoriano added docs review Filebeat Filebeat containers Related to containers use case labels Feb 21, 2019
@jsoriano jsoriano self-assigned this Feb 21, 2019
@jsoriano jsoriano requested a review from a team as a code owner February 21, 2019 11:00
@jsoriano
Copy link
Member Author

jenkins test this again please

@jsoriano
Copy link
Member Author

jenkins, test this

@jsoriano jsoriano added the Team:Integrations Label for the Integrations team label Feb 22, 2019
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the merge conflict, it looks good 👍

@vjsamuel
Copy link
Contributor

@jsoriano thanks much for this :)

@jsoriano jsoriano merged commit 93e3b59 into elastic:master Feb 26, 2019
@jsoriano jsoriano deleted the docker-input-paths-doc branch February 26, 2019 09:35
@AntonioMeireles
Copy link

hi all!

is there any hope of having this and #10687 backported to 6.x beats stream ?

thanks in advance!

@jsoriano
Copy link
Member Author

@AntonioMeireles in principle these changes will only be available in 7.X, there are still some more things to better support CRI-O.

@AntonioMeireles
Copy link

@jsoref many thanks for your quick reply.

FWIW, IMHO, support for cri-o (and perhaps containerd, and in general being agnostic to CRI runtimes in use) is absolutely critical in order for beats to be truly relevant and successful in the k8s space, as docker is less used every day, so the sooner it gets GA the better ;-)

@jsoref
Copy link
Contributor

jsoref commented Feb 28, 2019

@AntonioMeireles: did you reference the wrong account?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Related to containers use case docs Filebeat Filebeat review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants