-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow namespace: "*" for cloudwatch metricset #14971
Merged
kaiyan-sheng
merged 6 commits into
elastic:master
from
kaiyan-sheng:use_wildcard_namespace
Dec 15, 2019
Merged
Allow namespace: "*" for cloudwatch metricset #14971
kaiyan-sheng
merged 6 commits into
elastic:master
from
kaiyan-sheng:use_wildcard_namespace
Dec 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
added
Metricbeat
Metricbeat
Team:Integrations
Label for the Integrations team
test-plan
Add this PR to be manual test plan
needs_backport
PR is waiting to be backported to other branches.
review
labels
Dec 6, 2019
mtojek
approved these changes
Dec 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Does it mean we can deprecate all other modules built upon CloudWatch?
sayden
approved these changes
Dec 12, 2019
kaiyan-sheng
added
v7.6.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Metricbeat
Metricbeat
review
Team:Integrations
Label for the Integrations team
test-plan
Add this PR to be manual test plan
test-plan-ok
This PR passed manual testing
v7.6.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to run cloudwatch metricset with
namespace: "*"
and ListMetrics API did what we expected: it returned all metrics exists in that AWS account and was able to use to obtain statistical data.Here is what cloudwatch metricset collected:
The problem is:
statistic
andperiod
are defined for all metrics. For example, AWS/Usage metrics should be collected every 1 minute instead of every 5 minutes(data loss in this case). Also some metrics like AWS/Billing, should be collected every 6 hours or 12 hours instead of every 5 minutes(introduced extra cost in this case).The limitations are documented in doc under cloudwatch metricset.
closes #14965
How to test this
In your AWS account, please make sure the services are from more than one namespace.
Enable aws module in Metricbeat and change configuration file aws.yml to be:
Then start Metricbeat. You should be able to see metrics from all existing services from all different namespaces(with only *.avg metrics).