Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #14971 to 7.x: Allow namespace: "*" for cloudwatch metricset #15119

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Cherry-pick #14971 to 7.x: Allow namespace: "*" for cloudwatch metricset #15119

merged 2 commits into from
Dec 16, 2019

Conversation

kaiyan-sheng
Copy link
Contributor

Cherry-pick of PR #14971 to 7.x branch. Original message:

I tried to run cloudwatch metricset with namespace: "*" and ListMetrics API did what we expected: it returned all metrics exists in that AWS account and was able to use to obtain statistical data.

- module: aws
  period: 300s
  credential_profile_name: elastic-test
  metricsets:
    - cloudwatch
  metrics:
    - namespace: "*"
      statistic: ["Average"]

Here is what cloudwatch metricset collected:
Screen Shot 2019-12-05 at 1 42 46 PM

The problem is: statistic and period are defined for all metrics. For example, AWS/Usage metrics should be collected every 1 minute instead of every 5 minutes(data loss in this case). Also some metrics like AWS/Billing, should be collected every 6 hours or 12 hours instead of every 5 minutes(introduced extra cost in this case).

The limitations are documented in doc under cloudwatch metricset.
closes #14965

* Allow namespace: "*" for cloudwatch metricset

(cherry picked from commit 83b309d)
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner December 16, 2019 14:19
@kaiyan-sheng kaiyan-sheng self-assigned this Dec 16, 2019
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@sayden sayden self-requested a review December 16, 2019 18:52
@kaiyan-sheng kaiyan-sheng merged commit c226819 into elastic:7.x Dec 16, 2019
@kaiyan-sheng kaiyan-sheng deleted the backport_14971_7.x branch December 16, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants