Move one level up the sections in the configuration file #1544
Conversation
monicasarbu
added
in progress
| # Configure the ports where to listen for NFS traffic. You can disable | ||
| # the NFS protocol by commenting out the list of ports. | ||
| ports: [2049] | ||
| packetbeat.protocols.icmp: |
There was a problem hiding this comment.
Isn't the "move one level up" already done with packetbeat.protocols?
There was a problem hiding this comment.
I moved them one more level up. I think it's easier to read the configuration file like this. I think it's similar with what ES has now.
|
@monicasarbu I think that is in general a good change. What I'm not sure about is our "logic"? When do we exactly use the dot nation, and when exactly sub points? Would be good to have a common logic that we can always apply. |
monicasarbu
force-pushed
the
move_one_level_up_config
branch
2 times, most recently
from
e7c352e to
e5b2cd0
Compare
|
@ruflin @tsg @urso @andrewkroh I finished changing all the config files. Please let me know what you think about the new structure. |
monicasarbu
added
review
and removed
in progress
| cpu_per_core: false | ||
|
|
||
| # per system statistics, by default is true | ||
| stats.system: true |
There was a problem hiding this comment.
for topbeat I think it makes sense to have a fully flat config:
topbeat.period: ...
topbeat.procs:
topbeat.stats.system: ...
There was a problem hiding this comment.
Or the follwoing would als be fine from my perpsective:
topbeat.period
topbeat.procs
topbeat.stats:
system: ...
process: ...
|
I like the new structure, but change looks very minimal. I don't think this prevents people from messing up filebeat prospector config. packetbeat, filebeat look good. For topbeat/winlogbeat i'd rather flatten more. |
|
|
||
| ######################### Filebeat general configuration ############################# | ||
|
|
||
| filebeat: |
There was a problem hiding this comment.
I quite like the idea of separating general config and prospectors. Should we even comment out "filebeat" here as all sub config options are commented out?
|
Changes look good to me. See comments above. In a second step we should verify that all config options which actually exist are also in the config file. So in a third step we can potentially create a minimized option. |
|
BTW: One idea to create the minimized option of the config: Remove all fields which are commented out in the config could work. |
|
@monicasarbu It would be good to also update the config files we use for system tests with the above changes to make sure all the changes work as expected. |
|
@monicasarbu One of the configtest system tests seems to fail ... Ping when it's fixed, happy to merge and go from there. |
monicasarbu
force-pushed
the
move_one_level_up_config
branch
from
0b9992e to
a3fe239
Compare
Little changes content wise, but some style changes: * Use ###, ===, and --- headers to indicate hierarchy. This makes it easier to skim the config file. Idea stolen from elasticsearch.yml * Unindent filebeat prospectors and metricbeat modules by one level. This is still valid yaml, and fewer spaces make it harder to mess up the white spaces. * Reorganized a bit the logging config * Moved the "general" libbeat section before the outputs * Other fairly minor changes to the beats yaml files. This is a follow up of elastic#1544 and part of elastic#1417.
Little changes content wise, but some style changes: * Use ###, ===, and --- headers to indicate hierarchy. This makes it easier to skim the config file. Idea stolen from elasticsearch.yml * Unindent filebeat prospectors and metricbeat modules by one level. This is still valid yaml, and fewer spaces make it harder to mess up the white spaces. * Reorganized a bit the logging config * Moved the "general" libbeat section before the outputs * Other fairly minor changes to the beats yaml files. This is a follow up of #1544 and part of #1417. * Added a new line in front of the libbeat options * Make the styling changes for Metricbeat in automation
Based on the changed done in #1490, I am proposing the following structure of the configuration file where I move all the sections one level up all.
Implements part of #1417.
The changes should affect the following configuration files: