Configuration files restyling #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Little changes content wise, but some style changes: * Use ###, ===, and --- headers to indicate hierarchy. This makes it easier to skim the config file. Idea stolen from elasticsearch.yml * Unindent filebeat prospectors and metricbeat modules by one level. This is still valid yaml, and fewer spaces make it harder to mess up the white spaces. * Reorganized a bit the logging config * Moved the "general" libbeat section before the outputs * Other fairly minor changes to the beats yaml files. This is a follow up of elastic#1544 and part of elastic#1417.
|
These are the "full" config files. Creating the "short" ones (which will also become the defaults) will come in a future PR. |
| @@ -1,192 +1,189 @@ | |||
| ################### Filebeat Configuration Example ######################### | |||
| ###################### Filebeat Configuration Example ######################### | |||
There was a problem hiding this comment.
Perhaps we can remove the example part and use "Example" for the short one then.
There was a problem hiding this comment.
I will do that in the PR adding the short ones, because I'm thinking the full and short should have a header mentioning the other option.
|
LGTM. See notes. I like the new styling with the headers. |
|
Comments should be addressed. |
| @@ -1,4 +1,4 @@ | |||
| # Apache Module | |||
| #----------------------------- Apache Module ---------------------------------- | |||
There was a problem hiding this comment.
I hope to auto generate this line in the future based on a name entry in fields.yml.
|
LGTM. We should probably review all the docs after we finished all the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little changes content wise, but some style changes:
easier to skim the config file. Idea stolen from elasticsearch.yml
This is still valid yaml, and fewer spaces make it harder to mess up the
white spaces.
This is a follow up of #1544 and part of #1417.