Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent] Rename agent to elastic-agent #17391

Merged
merged 9 commits into from
Apr 2, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Apr 1, 2020

What does this PR do?

This PR renames agent to elastic-agent.
packaging tested.
configuration variables such as agent.id are kept the same without a name change.

Why is it important?

To provide less generic name for executable

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes #17239

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Project:fleet)

@michalpristas michalpristas changed the title Agent rename [Agent] Rename agent to elastic-agent Apr 1, 2020
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small details in the YAML files we should use the right capitalization "Elastic Agent" without the dash.

@@ -1,5 +1,5 @@
###################### Agent Configuration Example #########################

# This file is an example configuration file highlighting only the most common
# options. The agent.reference.yml file from the same directory contains all the
# options. The elastic-agent.reference.yml file from the same directory contains all the
# supported options with more comments. You can use it as a reference.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the YAML of documentation we should use the right capitalization to represent the product: "Elastic Agent"

@ph
Copy link
Contributor

ph commented Apr 1, 2020

@michalpristas I've tested locally, build the packages and play with it seems to be fine. I just saw with the latest changes in the CI we do not test the agent with Jenkins anymore. I am going to track that.

@michalpristas michalpristas merged commit 66609a3 into elastic:master Apr 2, 2020
@ph ph added the needs_backport PR is waiting to be backported to other branches. label Apr 7, 2020
@ph ph added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 8, 2020
ph pushed a commit to ph/beats that referenced this pull request Apr 10, 2020
[Agent] Rename agent to elastic-agent (elastic#17391)

(cherry picked from commit 66609a3)
ph added a commit that referenced this pull request Apr 14, 2020
)

* [Agent] Rename agent to elastic-agent (#17391)

[Agent] Rename agent to elastic-agent (#17391)

(cherry picked from commit 66609a3)

* Add Elastic Agent in the Jenkinsfile (#17445)

* Add Elastic Agent in the Jenkinsfile

With the recent moves to Jenkins pipeline the Elastic Agent project was
not currently tested.

* Add Elastic Agent in the Jenkinsfile (#17445)

* Add Elastic Agent in the Jenkinsfile

With the recent moves to Jenkins pipeline the Elastic Agent project was
not currently tested.

* [Agent] Fix merge of config (#17399)

[Agent] Fix merge of config #17399

* [Agent] Handle abs paths on windows correctly (#17461)

* handle windows correctly

* Missing commits from the initial merges of the agent -> master

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Agent] Rename our binary from agent to elastic-agent
3 participants