Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elastic Agent in the Jenkinsfile #17445

Merged
merged 2 commits into from
Apr 3, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented Apr 2, 2020

What does this PR do?

With the recent moves to Jenkins pipeline the Elastic Agent project was
not currently tested.

Why is it important?

To run the tests for the project.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

Jenkinsfile Outdated Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from typos looks good, please fix before merge

With the recent moves to Jenkins pipeline the Elastic Agent project was
not currently tested.
@ph
Copy link
Contributor Author

ph commented Apr 2, 2020

@michalpristas I've created this issue #17449, we don't our logic right when we deal with joining path for the install hooks. I've disabled the test here.

@ph ph added the needs_backport PR is waiting to be backported to other branches. label Apr 2, 2020
{"/a", "/a/b/c", "\\a\\b\\c", true},
{"/a", "/A/b/c", "\\a\\b\\c", true},
},
// (Windows issue) See issue:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michalpristas
Copy link
Contributor

@ph issue with windows is fixed here #17461

@ph
Copy link
Contributor Author

ph commented Apr 3, 2020

Jenkins test this please

@ph
Copy link
Contributor Author

ph commented Apr 3, 2020

jenkins run the tests please

@ph
Copy link
Contributor Author

ph commented Apr 3, 2020

I am going to merge this as is, and fallback on travis for everything mac related.

@ph ph merged commit dcb8d8b into elastic:master Apr 3, 2020
@ph
Copy link
Contributor Author

ph commented Apr 8, 2020

backported in #17599

@ph ph removed the needs_backport PR is waiting to be backported to other branches. label Apr 8, 2020
ph added a commit to ph/beats that referenced this pull request Apr 10, 2020
* Add Elastic Agent in the Jenkinsfile

With the recent moves to Jenkins pipeline the Elastic Agent project was
not currently tested.
ph added a commit to ph/beats that referenced this pull request Apr 10, 2020
* Add Elastic Agent in the Jenkinsfile

With the recent moves to Jenkins pipeline the Elastic Agent project was
not currently tested.
ph added a commit that referenced this pull request Apr 14, 2020
)

* [Agent] Rename agent to elastic-agent (#17391)

[Agent] Rename agent to elastic-agent (#17391)

(cherry picked from commit 66609a3)

* Add Elastic Agent in the Jenkinsfile (#17445)

* Add Elastic Agent in the Jenkinsfile

With the recent moves to Jenkins pipeline the Elastic Agent project was
not currently tested.

* Add Elastic Agent in the Jenkinsfile (#17445)

* Add Elastic Agent in the Jenkinsfile

With the recent moves to Jenkins pipeline the Elastic Agent project was
not currently tested.

* [Agent] Fix merge of config (#17399)

[Agent] Fix merge of config #17399

* [Agent] Handle abs paths on windows correctly (#17461)

* handle windows correctly

* Missing commits from the initial merges of the agent -> master

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants